You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
record controlled MZ 1.10.0 player-start deletion and five-case persistence-tolerance evidence
record a controlled tileset-name rename observation
disclose that the current unsigned player-start projection rejects an observed saved negative-coordinate state
propose ADR 0014, which changes player-start coordinates to i64 and advances the executable-wide CLI JSON schema to version 2
remove a duplicated capability phrase left by an earlier README conflict resolution
Why
Direct editor evidence contradicted the provisional unsigned-coordinate assumption in ADRs 0009 and 0010. MZ 1.10.0 saved startX = -1 and startY = -1 without normalizing them. The documentation now separates observed persistence tolerance from validity or runtime claims, and the proposed ADR defines a bounded corrective contract before code changes begin.
Impact
This PR changes documentation only. ADR 0014 remains Proposed and implementation is intentionally deferred until maintainer acceptance. If accepted, the later implementation will make Rust coordinate fields signed and advance all CLI JSON reports from schema version 1 to 2 because the executable currently uses one global schema number.
Independent contract evaluation completed. I recommend accepting ADR 0014 as proposed.
The evidence supports signed storage for startX/startY without expanding the unrelated map-ID domain. i64 is explicitly a Tilewright representation bound rather than an MZ limit; negative and upper-bound coordinates answer the same contextual rectangle question through OutOfBounds; and the executable-wide JSON schema advance to 2 makes the successful value-domain change visible to script consumers. Existing accepted ADRs remain unchanged as historical records and are superseded only for these coordinate clauses.
No implementation is included in this PR. The complete local Rust quality gate passed.
Independent review complete with no actionable findings. I reviewed the evidence provenance and claim strength, ADR/API and CLI schema contract, compatibility wording, cross-document consistency, and the exact PR head (0f68063). The full locked local Rust quality gate also passes. From this review, the PR is ready for maintainer acceptance and merge once it is taken out of draft and the required repository checks complete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
i64and advances the executable-wide CLI JSON schema to version 2Why
Direct editor evidence contradicted the provisional unsigned-coordinate assumption in ADRs 0009 and 0010. MZ 1.10.0 saved
startX = -1andstartY = -1without normalizing them. The documentation now separates observed persistence tolerance from validity or runtime claims, and the proposed ADR defines a bounded corrective contract before code changes begin.Impact
This PR changes documentation only. ADR 0014 remains Proposed and implementation is intentionally deferred until maintainer acceptance. If accepted, the later implementation will make Rust coordinate fields signed and advance all CLI JSON reports from schema version 1 to 2 because the executable currently uses one global schema number.
Verification
git diff --checkcargo fmt --all --checkcargo check --workspace --all-targets --all-featurescargo test --workspace --all-targets --all-featurescargo clippy --workspace --all-targets --all-features -- -D warningsRUSTDOCFLAGS="-D warnings" cargo doc --workspace --all-features --no-depsAll checks passed locally.
Review focus
i64is the right explicit Tilewright representation bound without implying an MZ boundOutOfBoundsfor negative and upper-bound coordinates is preferable to a new finding category