fix(types): honor generic variance for same-class assignments - #9010
Open
chess10kp wants to merge 6 commits into
Open
fix(types): honor generic variance for same-class assignments#9010chess10kp wants to merge 6 commits into
chess10kp wants to merge 6 commits into
Conversation
Split bidirectional invariant checks into separate ifs to remain lowerable. Also handle both LiteralString<->str directions and retain UnknownType skip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8550
Also fixes the same mutable-container covariance hole reported in #8580.
Summary
TypeEvaluator._assign_classalready applied declared variance when comparing a generic subclass with a generic base, but the same-class path always used one-wayassign_type. This acceptedlist[Dog]aslist[Animal]even thoughlistis invariant.This patch centralizes generic argument comparison and applies:
The helper is used by both same-class and generic-base comparisons. Unknown destination arguments remain open for inferred tuple filters.
Verification
jac checkacceptedlist[Dog]passed tolist[Animal].E1053: Cannot assign list[Dog] to parameter 'xs' of type list[Animal].cd jac && jac test tests/compiler/passes/test_checker_bugs.jac --test_name bug_8550_same_class_generic_variance -x(1 passed).