Skip to content

Added prompt option to the authorizationParams array#17

Open
martinlaukkanen wants to merge 1 commit into
jaredhanson:masterfrom
martinlaukkanen:patch-1
Open

Added prompt option to the authorizationParams array#17
martinlaukkanen wants to merge 1 commit into
jaredhanson:masterfrom
martinlaukkanen:patch-1

Conversation

@martinlaukkanen

Copy link
Copy Markdown

In order to enable forced login prompting parameter, e.g.: &prompt=login, see Issue #16.

In order to enable forced login prompting parameter, e.g.: &prompt=login, see Issue jaredhanson#16.
@vhmth

vhmth commented Aug 22, 2017

Copy link
Copy Markdown

Not sure why the build is failing (can't find the output), but this should go through. prompt is something we should be implementing to the OAuth spec.

@vhmth

vhmth commented Aug 22, 2017

Copy link
Copy Markdown

Ref: #16

@vhmth

vhmth commented Aug 22, 2017

Copy link
Copy Markdown

Looks like this is resulting in an empty redirect_uri param being added?

https://travis-ci.org/jaredhanson/passport-windowslive/jobs/164307688

@vhmth

vhmth commented Aug 22, 2017

Copy link
Copy Markdown

Err actually, seems like that's what the test is expecting? Strange

https://github.com/jaredhanson/passport-windowslive/blob/master/test/strategy.test.js#L52

@vhmth

vhmth commented Aug 25, 2017

Copy link
Copy Markdown

@martinlaukkanen did you want me to take this on to fix the tests? I don't mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants