Allow subset of operations - #38
Open
blustrini wants to merge 4 commits into
Open
Conversation
Author
|
Changed the input argument to types and didn't change the tests, so they have failed. |
Author
|
Tests seem to pass, but probably needs some more tests to test the new functionality. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow subset of operations, keeping back-compatibility (issue #37).
Operation type still passed as
--type, but can now concatenate operation types, e.g.--type=+-to do addition and subtraction.--type=mixstill does all the operations.Types are now passed to the object as a tuple of allowed operation strings, e.g.
('+', '-'), which saved to the attributeall_types. Methodgenerate_questionthen draws fromself.all_typesevery time.This is my first ever pull-request, btw so let me know if I am doing anything wrong.