Skip to content

[translation] Fix src/plugins/ieviewer/markdown.cpp comments#266

Closed
janrysavy wants to merge 710 commits into
mainfrom
codex/ostr-real-smoke-run-1777200310482-src-plugins-ieviewer-markdown-cpp
Closed

[translation] Fix src/plugins/ieviewer/markdown.cpp comments#266
janrysavy wants to merge 710 commits into
mainfrom
codex/ostr-real-smoke-run-1777200310482-src-plugins-ieviewer-markdown-cpp

Conversation

@janrysavy

Copy link
Copy Markdown
Owner

Summary

  • Applies 1 validated translated-comment rewrite(s) from packet packet-pr-real-smoke-run-1777200310482.
  • Changes 1 file(s): src/plugins/ieviewer/markdown.cpp.
  • Keeps delivery deterministic; no LLM request is made during PR publication.

Provider

  • Profile: manual_pro
  • Normalized response: D:\Source\OSTranslationReview\.local\pr-publish-real-smoke\run-1777200310482\packet\imported\normalized-response.json

Verification

  • Guard passed for 1 file(s).
  • Inline review comments prepared: 1.
  • git diff --check is run by publish-pr before commit in non-dry-run mode.

Refines translated comments in src/bugreprt.cpp.

Model: OpenAI GPT-5.4

Verification: Reviewed PR OpenSalamander#840 for src/bugreprt.cpp, confirmed the CommentsTranslationProject translated header marker, reran clang-format on the PR head branch, and verified the final branch diff remained comment-only before squash merge.

Telemetry: No additional provider-backed review stages were required during final PR review; this merge uses the existing artifact-backed translation branch with a final clang-format normalization commit.
Refines translated comments in src/dialogs.cpp.

Model: OpenAI GPT-5.4

Verification: Reviewed PR OpenSalamander#849 for src/dialogs.cpp, confirmed the CommentsTranslationProject translated header marker, reran clang-format on the PR head branch, and verified the final branch diff remained comment-only before squash merge.

Telemetry: No additional provider-backed review stages were required during final PR review; this merge uses the existing artifact-backed translation branch with a final clang-format normalization commit.
Refines translated comments in src/mainwnd3.cpp.

Model: OpenAI GPT-5.4

Verification: Reviewed PR OpenSalamander#890 for src/mainwnd3.cpp, confirmed the CommentsTranslationProject translated header marker, reran clang-format on the PR head branch, and verified the final branch diff remained comment-only before squash merge.

Telemetry: No additional provider-backed review stages were required during final PR review; this merge uses the existing artifact-backed translation branch with a final clang-format normalization commit.
Refines translated comments in src/pack1.cpp.

Model: OpenAI GPT-5.4

Verification: Reviewed PR OpenSalamander#903 for src/pack1.cpp, confirmed the CommentsTranslationProject translated header marker, reran clang-format on the PR head branch, and verified the final branch diff remained comment-only before squash merge.

Telemetry: No additional provider-backed review stages were required during final PR review; this merge uses the existing artifact-backed translation branch with a final clang-format normalization commit.
Refines translated comments in src/plugins.h.

Model: OpenAI GPT-5.4

Verification: Reviewed PR OpenSalamander#908 for src/plugins.h, confirmed the CommentsTranslationProject translated header marker, reran clang-format on the PR head branch, and verified the final branch diff remained comment-only before squash merge.

Telemetry: No additional provider-backed review stages were required during final PR review; this merge uses the existing artifact-backed translation branch with a final clang-format normalization commit.
Refines translated comments in src/plugins1.cpp.

Model: OpenAI GPT-5.4

Verification: Reviewed PR OpenSalamander#909 for src/plugins1.cpp, confirmed the CommentsTranslationProject translated header marker, reran clang-format on the PR head branch, and verified the final branch diff remained comment-only before squash merge.

Telemetry: No additional provider-backed review stages were required during final PR review; this merge uses the existing artifact-backed translation branch with a final clang-format normalization commit.
Refines translated comments in src/salamdr3.cpp.

Model: OpenAI GPT-5.4

Verification: Reviewed PR OpenSalamander#919 for src/salamdr3.cpp, confirmed the CommentsTranslationProject translated header marker, reran clang-format on the PR head branch, and verified the final branch diff remained comment-only before squash merge.

Telemetry: No additional provider-backed review stages were required during final PR review; this merge uses the existing artifact-backed translation branch with a final clang-format normalization commit.
Refines translated comments in src/salamdr7.cpp.

Model: OpenAI GPT-5.4

Verification: Reviewed PR OpenSalamander#923 for src/salamdr7.cpp, confirmed the CommentsTranslationProject translated header marker, reran clang-format on the PR head branch, and verified the final branch diff remained comment-only before squash merge.

Telemetry: No additional provider-backed review stages were required during final PR review; this merge uses the existing artifact-backed translation branch with a final clang-format normalization commit.
Refines translated comments in src/salshlib.h.

Model: OpenAI GPT-5.4

Verification: Reviewed PR OpenSalamander#928 for src/salshlib.h, confirmed the CommentsTranslationProject translated header marker, reran clang-format on the PR head branch, and verified the final branch diff remained comment-only before squash merge.

Telemetry: No additional provider-backed review stages were required during final PR review; this merge uses the existing artifact-backed translation branch with a final clang-format normalization commit.
Refines translated comments in src/shellib.h.

Model: OpenAI GPT-5.4

Verification: Reviewed PR OpenSalamander#931 for src/shellib.h, confirmed the CommentsTranslationProject translated header marker, reran clang-format on the PR head branch, and verified the final branch diff remained comment-only before squash merge.

Telemetry: No additional provider-backed review stages were required during final PR review; this merge uses the existing artifact-backed translation branch with a final clang-format normalization commit.
Refines translated comments in src/stswnd.cpp.

Model: OpenAI GPT-5.4

Verification: Reviewed PR OpenSalamander#944 for src/stswnd.cpp, confirmed the CommentsTranslationProject translated header marker, reran clang-format on the PR head branch, and verified the final branch diff remained comment-only before squash merge.

Telemetry: No additional provider-backed review stages were required during final PR review; this merge uses the existing artifact-backed translation branch with a final clang-format normalization commit.
Refines translated comments in src/versinfo.h.

Model: OpenAI GPT-5.4

Verification: Reviewed PR OpenSalamander#945 for src/versinfo.h, confirmed the CommentsTranslationProject translated header marker, reran clang-format on the PR head branch, and verified the final branch diff remained comment-only before squash merge.

Telemetry: No additional provider-backed review stages were required during final PR review; this merge uses the existing artifact-backed translation branch with a final clang-format normalization commit.
Refines translated comments in src/viewer.h.

Model: OpenAI GPT-5.4

Verification: Reviewed PR OpenSalamander#946 for src/viewer.h, confirmed the CommentsTranslationProject translated header marker, reran clang-format on the PR head branch, and verified the final branch diff remained comment-only before squash merge.

Telemetry: No additional provider-backed review stages were required during final PR review; this merge uses the existing artifact-backed translation branch with a final clang-format normalization commit.
Refines translated comments in src/worker.h.

Model: OpenAI GPT-5.4

Verification: Reviewed PR OpenSalamander#949 for src/worker.h, confirmed the CommentsTranslationProject translated header marker, reran clang-format on the PR head branch, and verified the final branch diff remained comment-only before squash merge.

Telemetry: No additional provider-backed review stages were required during final PR review; this merge uses the existing artifact-backed translation branch with a final clang-format normalization commit.
Refines translated comments in src/viewer3.cpp.

Model: OpenAI GPT-5.4

Verification: Reviewed PR OpenSalamander#950 for src/viewer3.cpp, confirmed the CommentsTranslationProject translated header marker, reran clang-format on the PR head branch, and verified the final branch diff remained comment-only before squash merge.

Telemetry: No additional provider-backed review stages were required during final PR review; this merge uses the existing artifact-backed translation branch with a final clang-format normalization commit.
Refines translated comments in src/zip.h.

Model: OpenAI GPT-5.4

Verification: Reviewed PR OpenSalamander#951 for src/zip.h, confirmed the CommentsTranslationProject translated header marker, reran clang-format on the PR head branch, and verified the final branch diff remained comment-only before squash merge.

Telemetry: No additional provider-backed review stages were required during final PR review; this merge uses the existing artifact-backed translation branch with a final clang-format normalization commit.
Refines translated comments in src/plugins/undelete/dialogs.cpp.

Model: OpenAI GPT-5.4

Verification: Reviewed PR OpenSalamander#754 for src/plugins/undelete/dialogs.cpp, restored the required CommentsTranslationProject translated marker on the head branch, reran clang-format, and confirmed the final branch diff remained comment-only before squash merge.

Telemetry: No additional provider-backed review stages were required during final PR review; this merge uses the existing artifact-backed translation branch with a metadata repair commit for the translated-file marker when needed.
Refines translated comments in src/plugins/undelete/fs1.cpp.

Model: OpenAI GPT-5.4

Verification: Reviewed PR OpenSalamander#755 for src/plugins/undelete/fs1.cpp, restored the required CommentsTranslationProject translated marker on the head branch, reran clang-format, and confirmed the final branch diff remained comment-only before squash merge.

Telemetry: No additional provider-backed review stages were required during final PR review; this merge uses the existing artifact-backed translation branch with a metadata repair commit for the translated-file marker when needed.
Refines translated comments in src/plugins/undelete/fs2.cpp.

Model: OpenAI GPT-5.4

Verification: Reviewed PR OpenSalamander#756 for src/plugins/undelete/fs2.cpp, restored the required CommentsTranslationProject translated marker on the head branch, reran clang-format, and confirmed the final branch diff remained comment-only before squash merge.

Telemetry: No additional provider-backed review stages were required during final PR review; this merge uses the existing artifact-backed translation branch with a metadata repair commit for the translated-file marker when needed.
Refines translated comments in src/plugins/undelete/restore.cpp.

Model: OpenAI GPT-5.4

Verification: Reviewed PR OpenSalamander#757 for src/plugins/undelete/restore.cpp, restored the required CommentsTranslationProject translated marker on the head branch, reran clang-format, and confirmed the final branch diff remained comment-only before squash merge.

Telemetry: No additional provider-backed review stages were required during final PR review; this merge uses the existing artifact-backed translation branch with a metadata repair commit for the translated-file marker when needed.
Refines translated comments in src/plugins/undelete/undelete.cpp.

Model: OpenAI GPT-5.4

Verification: Reviewed PR OpenSalamander#758 for src/plugins/undelete/undelete.cpp, restored the required CommentsTranslationProject translated marker on the head branch, reran clang-format, and confirmed the final branch diff remained comment-only before squash merge.

Telemetry: No additional provider-backed review stages were required during final PR review; this merge uses the existing artifact-backed translation branch with a metadata repair commit for the translated-file marker when needed.
Refines translated comments in src/plugins/undelete/undelete.h.

Model: OpenAI GPT-5.4

Verification: Reviewed PR OpenSalamander#759 for src/plugins/undelete/undelete.h, restored the required CommentsTranslationProject translated marker on the head branch, reran clang-format, and confirmed the final branch diff remained comment-only before squash merge.

Telemetry: No additional provider-backed review stages were required during final PR review; this merge uses the existing artifact-backed translation branch with a metadata repair commit for the translated-file marker when needed.
Refines translated comments in src/plugins/undelete/library/arraylt.h.

Model: OpenAI GPT-5.4

Verification: Reviewed PR OpenSalamander#760 for src/plugins/undelete/library/arraylt.h, restored the required CommentsTranslationProject translated marker on the head branch, reran clang-format, and confirmed the final branch diff remained comment-only before squash merge.

Telemetry: No additional provider-backed review stages were required during final PR review; this merge uses the existing artifact-backed translation branch with a metadata repair commit for the translated-file marker when needed.
Refines translated comments in src/plugins/undelete/library/bitmap.h.

Model: OpenAI GPT-5.4

Verification: Reviewed PR OpenSalamander#761 for src/plugins/undelete/library/bitmap.h, restored the required CommentsTranslationProject translated marker on the head branch, reran clang-format, and confirmed the final branch diff remained comment-only before squash merge.

Telemetry: No additional provider-backed review stages were required during final PR review; this merge uses the existing artifact-backed translation branch with a metadata repair commit for the translated-file marker when needed.
Refines translated comments in src/plugins/undelete/library/dataruns.h.

Model: OpenAI GPT-5.4

Verification: Reviewed PR OpenSalamander#762 for src/plugins/undelete/library/dataruns.h, restored the required CommentsTranslationProject translated marker on the head branch, reran clang-format, and confirmed the final branch diff remained comment-only before squash merge.

Telemetry: No additional provider-backed review stages were required during final PR review; this merge uses the existing artifact-backed translation branch with a metadata repair commit for the translated-file marker when needed.
Refines translated comments in src/plugins/undelete/library/exfat.h.

Model: OpenAI GPT-5.4

Verification: Reviewed PR OpenSalamander#763 for src/plugins/undelete/library/exfat.h, restored the required CommentsTranslationProject translated marker on the head branch, reran clang-format, and confirmed the final branch diff remained comment-only before squash merge.

Telemetry: No additional provider-backed review stages were required during final PR review; this merge uses the existing artifact-backed translation branch with a metadata repair commit for the translated-file marker when needed.
Refines translated comments in src/plugins/undelete/library/fat.cpp.

Model: OpenAI GPT-5.4

Verification: Reviewed PR OpenSalamander#764 for src/plugins/undelete/library/fat.cpp, restored the required CommentsTranslationProject translated marker on the head branch, reran clang-format, and confirmed the final branch diff remained comment-only before squash merge.

Telemetry: No additional provider-backed review stages were required during final PR review; this merge uses the existing artifact-backed translation branch with a metadata repair commit for the translated-file marker when needed.
Refines translated comments in src/plugins/undelete/library/fat.h.

Model: OpenAI GPT-5.4

Verification: Reviewed PR OpenSalamander#765 for src/plugins/undelete/library/fat.h, restored the required CommentsTranslationProject translated marker on the head branch, reran clang-format, and confirmed the final branch diff remained comment-only before squash merge.

Telemetry: No additional provider-backed review stages were required during final PR review; this merge uses the existing artifact-backed translation branch with a metadata repair commit for the translated-file marker when needed.
Refines translated comments in src/plugins/undelete/library/miscstr.cpp.

Model: OpenAI GPT-5.4

Verification: Reviewed PR OpenSalamander#766 for src/plugins/undelete/library/miscstr.cpp, restored the required CommentsTranslationProject translated marker on the head branch, reran clang-format, and confirmed the final branch diff remained comment-only before squash merge.

Telemetry: No additional provider-backed review stages were required during final PR review; this merge uses the existing artifact-backed translation branch with a metadata repair commit for the translated-file marker when needed.
Refines translated comments in src/plugins/undelete/library/ntfs.h.

Model: OpenAI GPT-5.4

Verification: Reviewed PR OpenSalamander#767 for src/plugins/undelete/library/ntfs.h, restored the required CommentsTranslationProject translated marker on the head branch, reran clang-format, and confirmed the final branch diff remained comment-only before squash merge.

Telemetry: No additional provider-backed review stages were required during final PR review; this merge uses the existing artifact-backed translation branch with a metadata repair commit for the translated-file marker when needed.
janrysavy and others added 26 commits April 21, 2026 17:59
Refines translated comments in src/common/trace.h.

Model: OpenAI GPT-5.4

Verification: Full OSTranslation sequential review pipeline with requested review mode `codex`, actual review providers none, `--prompt-log-mode summary`, `--copilot-event-log summary`, AST grounding through clang, Codex model `gpt-5.4` with `--codex-reasoning medium`, Copilot model `gpt-5.4-mini`, and `--copilot-reasoning high`. 110 comment units, 110 review results, 110 resolved results, and 110 apply results. Branch-target comment guard passed for `src/common/trace.h` in strict and ignore-whitespace modes with 0 violations and 0 preprocessing failures. `git diff --check -- src/common/trace.h` completed without diff integrity failures.

Telemetry: Artifact-local provider usage was 9 requests total and 0 billing units. Codex 9 requests, 119,762 tokens; Copilot 0 requests, 0 tokens. Review reused 29 review-cache hits, 44 deterministic resolutions, 0 request batches.
Refines translated comments in src/common/dep/sqlite/precomp.h.

Model: OpenAI GPT-5.4

Verification: Full OSTranslation sequential review pipeline with requested review mode `codex`, actual review providers none, `--prompt-log-mode summary`, `--copilot-event-log summary`, AST grounding through clang, Codex model `gpt-5.4` with `--codex-reasoning medium`, Copilot model `gpt-5.4-mini`, and `--copilot-reasoning high`. 1 comment unit, 1 review result, 1 resolved result, and 1 apply result. Branch-target comment guard passed for `src/common/dep/sqlite/precomp.h` in strict and ignore-whitespace modes with 0 violations and 0 preprocessing failures. `git diff --check -- src/common/dep/sqlite/precomp.h` completed without diff integrity failures.

Telemetry: Artifact-local provider usage was 0 requests total and 0 billing units. Codex 0 requests, 0 tokens; Copilot 0 requests, 0 tokens. Review reused 0 request batches.
Refines translated comments in src/plugins/dbviewer/parser.cpp.

Model: OpenAI GPT-5.4

Verification: Full OSTranslation sequential review pipeline with requested review mode `codex`, actual review providers `codex`, `--prompt-log-mode summary`, `--copilot-event-log summary`, AST grounding through clang, Codex model `gpt-5.4` with `--codex-reasoning medium`, Copilot model `gpt-5.4-mini`, and `--copilot-reasoning high`. 48 comment units, 48 review results, 48 resolved results, and 48 apply results. Branch-target comment guard passed for `src/plugins/dbviewer/parser.cpp` in strict and ignore-whitespace modes with 0 violations and 0 preprocessing failures. `git diff --check -- src/plugins/dbviewer/parser.cpp` completed without diff integrity failures.

Telemetry: Artifact-local provider usage was 20 requests total and 0 billing units. Codex 20 requests, 273,492 tokens; Copilot 0 requests, 0 tokens. Review reused 7 deterministic resolutions, 8 request batches.
Refines translated comments in src/plugins/dbviewer/renmain.cpp.

Model: OpenAI GPT-5.4

Verification: Full OSTranslation sequential review pipeline with requested review mode `codex`, actual review providers `codex`, `--prompt-log-mode summary`, `--copilot-event-log summary`, AST grounding through clang, Codex model `gpt-5.4` with `--codex-reasoning medium`, Copilot model `gpt-5.4-mini`, and `--copilot-reasoning high`. 74 comment units, 74 review results, 74 resolved results, and 74 apply results. Branch-target comment guard passed for `src/plugins/dbviewer/renmain.cpp` in strict and ignore-whitespace modes with 0 violations and 0 preprocessing failures. `git diff --check -- src/plugins/dbviewer/renmain.cpp` completed without diff integrity failures.

Telemetry: Artifact-local provider usage was 17 requests total and 0 billing units. Codex 17 requests, 204,848 tokens; Copilot 0 requests, 0 tokens. Review reused 13 deterministic resolutions, 8 request batches.
Refines translated comments in src/plugins/ftp/operats5.cpp.

Model: OpenAI GPT-5.4

Verification: Full OSTranslation sequential review pipeline with requested review mode `codex`, actual review providers `codex`, `--prompt-log-mode summary`, `--copilot-event-log summary`, AST grounding through clang, Codex model `gpt-5.4` with `--codex-reasoning medium`, Copilot model `gpt-5.4-mini`, and `--copilot-reasoning high`. 261 comment units, 261 review results, 261 resolved results, and 261 apply results. Branch-target comment guard passed for `src/plugins/ftp/operats5.cpp` in strict and ignore-whitespace modes with 0 violations and 0 preprocessing failures. `git diff --check -- src/plugins/ftp/operats5.cpp` completed without diff integrity failures.

Telemetry: Artifact-local provider usage was 63 requests total and 0 billing units. Codex 63 requests, 610,057 tokens; Copilot 0 requests, 0 tokens. Review reused 26 deterministic resolutions, 51 request batches.
Refines translated comments in src/plugins/shared/dbg.h.

Model: OpenAI GPT-5.4

Verification: Full OSTranslation sequential review pipeline with requested review mode `codex`, actual review providers none, `--prompt-log-mode summary`, `--copilot-event-log summary`, AST grounding through clang, Codex model `gpt-5.4` with `--codex-reasoning medium`, Copilot model `gpt-5.4-mini`, and `--copilot-reasoning high`. 105 comment units, 105 review results, 105 resolved results, and 105 apply results. Branch-target comment guard passed for `src/plugins/shared/dbg.h` in strict and ignore-whitespace modes with 0 violations and 0 preprocessing failures. `git diff --check -- src/plugins/shared/dbg.h` completed without diff integrity failures.

Telemetry: Artifact-local provider usage was 25 requests total and 0 billing units. Codex 25 requests, 281,815 tokens; Copilot 0 requests, 0 tokens. Review reused 9 review-cache hits, 2 translation-memory hits (2 provider avoids), 43 deterministic resolutions, 0 request batches.
Refines translated comments in src/plugins/shared/lukas/resedit.cpp.

Model: OpenAI GPT-5.4

Verification: Full OSTranslation sequential review pipeline with requested review mode `codex`, actual review providers `codex`, `--prompt-log-mode summary`, `--copilot-event-log summary`, AST grounding through clang, Codex model `gpt-5.4` with `--codex-reasoning medium`, Copilot model `gpt-5.4-mini`, and `--copilot-reasoning high`. 34 comment units, 34 review results, 34 resolved results, and 34 apply results. Branch-target comment guard passed for `src/plugins/shared/lukas/resedit.cpp` in strict and ignore-whitespace modes with 0 violations and 0 preprocessing failures. `git diff --check -- src/plugins/shared/lukas/resedit.cpp` completed without diff integrity failures.

Telemetry: Artifact-local provider usage was 16 requests total and 0 billing units. Codex 16 requests, 153,431 tokens; Copilot 0 requests, 0 tokens. Review reused 13 deterministic resolutions, 1 request batch.
Refines translated comments in src/plugins/shared/spl_gui.h.

Model: OpenAI GPT-5.4

Verification: Full OSTranslation sequential review pipeline with requested review mode `codex`, actual review providers `codex`, `--prompt-log-mode summary`, `--copilot-event-log summary`, AST grounding through clang, Codex model `gpt-5.4` with `--codex-reasoning medium`, Copilot model `gpt-5.4-mini`, and `--copilot-reasoning high`. 295 comment units, 295 review results, 295 resolved results, and 295 apply results. Branch-target comment guard passed for `src/plugins/shared/spl_gui.h` in strict and ignore-whitespace modes with 0 violations and 0 preprocessing failures. `git diff --check -- src/plugins/shared/spl_gui.h` completed without diff integrity failures.

Telemetry: Artifact-local provider usage was 7 requests total and 0 billing units. Codex 7 requests, 15,976 tokens; Copilot 0 requests, 0 tokens. Review reused 30 review-cache hits, 1 translation-memory hit (1 provider avoid), 73 deterministic resolutions, 1 request batch.
Refines translated comments in src/plugins/shared/statics.rh2.

Model: OpenAI GPT-5.4

Verification: Full OSTranslation sequential review pipeline with requested review mode `codex`, actual review providers `codex`, `--prompt-log-mode summary`, `--copilot-event-log summary`, AST grounding through clang, Codex model `gpt-5.4` with `--codex-reasoning medium`, Copilot model `gpt-5.4-mini`, and `--copilot-reasoning high`. 6 comment units, 6 review results, 6 resolved results, and 6 apply results. Branch-target comment guard passed for `src/plugins/shared/statics.rh2` in strict and ignore-whitespace modes with 0 violations and 0 preprocessing failures. `git diff --check -- src/plugins/shared/statics.rh2` completed without diff integrity failures.

Telemetry: Artifact-local provider usage was 3 requests total and 0 billing units. Codex 3 requests, 25,116 tokens; Copilot 0 requests, 0 tokens. Review reused 4 deterministic resolutions, 2 request batches.
Refines translated comments in src/plugins/shared/versinfo.rc2.

Model: OpenAI GPT-5.4

Verification: Full OSTranslation sequential review pipeline with requested review mode `codex`, actual review providers `codex`, `--prompt-log-mode summary`, `--copilot-event-log summary`, AST grounding through clang, Codex model `gpt-5.4` with `--codex-reasoning medium`, Copilot model `gpt-5.4-mini`, and `--copilot-reasoning high`. 5 comment units, 5 review results, 5 resolved results, and 5 apply results. Branch-target comment guard passed for `src/plugins/shared/versinfo.rc2` in strict and ignore-whitespace modes with 0 violations and 0 preprocessing failures. `git diff --check -- src/plugins/shared/versinfo.rc2` completed without diff integrity failures.

Telemetry: Artifact-local provider usage was 4 requests total and 0 billing units. Codex 4 requests, 25,794 tokens; Copilot 0 requests, 0 tokens. Review reused 2 deterministic resolutions, 2 request batches.
Refines translated comments in src/plugins/zip/unreduce.cpp.

Model: OpenAI GPT-5.4

Verification: Full OSTranslation sequential review pipeline with requested review mode `codex`, actual review providers `codex`, `--prompt-log-mode summary`, `--copilot-event-log summary`, AST grounding through clang, Codex model `gpt-5.4` with `--codex-reasoning medium`, Copilot model `gpt-5.4-mini`, and `--copilot-reasoning high`. 36 comment units, 36 review results, 36 resolved results, and 36 apply results. Branch-target comment guard passed for `src/plugins/zip/unreduce.cpp` in strict and ignore-whitespace modes with 0 violations and 0 preprocessing failures. `git diff --check -- src/plugins/zip/unreduce.cpp` completed without diff integrity failures.

Telemetry: Artifact-local provider usage was 9 requests total and 0 billing units. Codex 9 requests, 96,256 tokens; Copilot 0 requests, 0 tokens. Review reused 12 deterministic resolutions, 3 request batches.
Refines translated comments in src/plugins/checksum/checksum.rh2.

Model: OpenAI GPT-5.4

Verification: Full OSTranslation sequential review pipeline with requested review mode `codex`, actual review providers `codex`, `--prompt-log-mode summary`, `--copilot-event-log summary`, AST grounding through clang, Codex model `gpt-5.4` with `--codex-reasoning medium`, Copilot model `gpt-5.4-mini`, and `--copilot-reasoning high`. 14 comment units, 14 review results, 14 resolved results, and 14 apply results. Branch-target comment guard passed for `src/plugins/checksum/checksum.rh2` in strict and ignore-whitespace modes with 0 violations and 0 preprocessing failures. `git diff --check -- src/plugins/checksum/checksum.rh2` completed without diff integrity failures.

Telemetry: Artifact-local provider usage was 1 request total and 0 billing units. Codex 1 request, 4,634 tokens; Copilot 0 requests, 0 tokens. Review reused 1 translation-memory hit (1 provider avoid), 3 deterministic resolutions, 1 request batch.
Refines translated comments in tools/salbreak/salbreak.cpp.

Model: OpenAI GPT-5.4

Verification: Full OSTranslation sequential review pipeline with requested review mode `codex`, actual review providers `codex`, `--prompt-log-mode summary`, `--copilot-event-log summary`, AST grounding through clang, Codex model `gpt-5.4` with `--codex-reasoning medium`, Copilot model `gpt-5.4-mini`, and `--copilot-reasoning high`. 46 comment units, 46 review results, 46 resolved results, and 46 apply results. Branch-target comment guard passed for `tools/salbreak/salbreak.cpp` in strict and ignore-whitespace modes with 0 violations and 0 preprocessing failures. `git diff --check -- tools/salbreak/salbreak.cpp` completed without diff integrity failures.

Telemetry: Artifact-local provider usage was 13 requests total and 0 billing units. Codex 13 requests, 170,333 tokens; Copilot 0 requests, 0 tokens. Review reused 2 deterministic resolutions, 5 request batches.
Provider: manual_pro
Pipeline: OSTranslationReview
Scope: validated translated-comment rewrites
@@ -116,7 +116,7 @@ IStream* ConvertMarkdownToHTML(const char* name)
sprintf_s(buff, "<!DOCTYPE html><html lang=\"cs\" dir=\"ltr\"><head><meta charset=\"utf-8\"><style>\n");
oStream->Write(buff, (ULONG)strlen(buff), &written);

// if we find CSS, inline it
// Inline CSS when the markdown contains a stylesheet.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// if we find CSS, inline it

Final English:

// Inline CSS when the markdown contains a stylesheet.

Rationale: Clarifies that the stylesheet is inlined when present.

@janrysavy

Copy link
Copy Markdown
Owner Author

Closing this smoke-test PR because the correct delivery shape is cross-repo OpenSalamander/salamander <= janrysavy/salamander, matching OpenSalamander#1093.

@janrysavy janrysavy closed this Apr 26, 2026
@janrysavy janrysavy deleted the codex/ostr-real-smoke-run-1777200310482-src-plugins-ieviewer-markdown-cpp branch April 26, 2026 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant