Conversation
janrueth
force-pushed
the
wip
branch
2 times, most recently
from
April 17, 2026 15:11
59a5b59 to
128a5ed
Compare
Consume the AEAD, PKey::generate, and TLS 1.2 PRF modules now merged upstream in cloudflare/boring (rev b0a4e451) and remove the local boring-additions and boring-sys-additions crates entirely. AEAD: replace boring_additions::aead::Crypter with boring::aead::AeadCtx. Adapt all seal_in_place/open_in_place call sites to the upstream parameter order (nonce, buffer, tag, aad) and the new slice return type. Cache max_overhead on BoringAeadCrypter since the upstream AeadCtx no longer stores it. PKey generation: replace manual EVP_PKEY_CTX FFI in ed_from_curve with a single PKey::generate(Id) call. TLS 1.2 PRF: replace raw CRYPTO_tls1_prf FFI (from boring-sys-additions) with boring::prf::tls1_prf. HMAC: replace manual HMAC_CTX FFI with boring::hmac::Hmac init/update/finalize API, removing all unsafe blocks from hmac.rs. Update panic-surface test allowlist for the changed HMAC expect messages and remove the boring-additions source scan root. Delete boring-additions (aead, evp, hmac wrappers + helper) and boring-sys-additions (CRYPTO_tls1_prf binding) crates and their workspace entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consume the AEAD, PKey::generate, and TLS 1.2 PRF modules now merged upstream in cloudflare/boring (rev b0a4e451) and remove the local boring-additions and boring-sys-additions crates entirely.
AEAD: replace boring_additions::aead::Crypter with boring::aead::AeadCtx. Adapt all seal_in_place/open_in_place call sites to the upstream parameter order (nonce, buffer, tag, aad) and the new slice return type. Cache max_overhead on BoringAeadCrypter since the upstream AeadCtx no longer stores it.
PKey generation: replace manual EVP_PKEY_CTX FFI in ed_from_curve with a single PKey::generate(Id) call.
TLS 1.2 PRF: replace raw CRYPTO_tls1_prf FFI (from boring-sys-additions) with boring::prf::tls1_prf.
HMAC: replace manual HMAC_CTX FFI with boring::hmac::Hmac init/update/finalize API, removing all unsafe blocks from hmac.rs.
Update panic-surface test allowlist for the changed HMAC expect messages and remove the boring-additions source scan root.
Delete boring-additions (aead, evp, hmac wrappers + helper) and boring-sys-additions (CRYPTO_tls1_prf binding) crates and their workspace entries.