Skip to content

Unpin setuptools_scm upper bound in setup_requires#207

Closed
Dodothereal wants to merge 1 commit into
janluke:masterfrom
Dodothereal:fix/206-unpin-setup-requires-from-setuptools-scm
Closed

Unpin setuptools_scm upper bound in setup_requires#207
Dodothereal wants to merge 1 commit into
janluke:masterfrom
Dodothereal:fix/206-unpin-setup-requires-from-setuptools-scm

Conversation

@Dodothereal

Copy link
Copy Markdown

Unpin setuptools_scm upper bound in setup_requires

Summary

setup.py pinned setuptools_scm to <10, which blocks installation whenever a
newer setuptools_scm (already released) is the only version available in the
environment. This PR removes the upper bound so any compatible setuptools_scm
release can satisfy the build requirement, as requested in the issue.

Fixes #206

Changes

  • setup.py: changed setup_requires=['setuptools_scm<10'] to
    setup_requires=['setuptools_scm'] (removes the <10 pin).

No other version constraints on setuptools_scm exist in the repository
(setup.cfg and the requirements/ files pin only setuptools, not
setuptools_scm; there is no pyproject.toml).

Testing

The change is a single metadata dependency pin; it has no runtime/code effect.
I verified by repository-wide search (grep -rn "setuptools_scm" --include=...)
that this was the only place the version was pinned, so no other file needs
updating. The sandbox used to run build/test commands (sandbox-run) is
currently unable to start on this VM (bwrap: setting up uid map: Permission denied, confirmed by bin/sandbox-selftest), so I could not run
python setup.py sdist/bdist_wheel against setuptools-scm>=10 here. The
maintainer's earlier feedback in the issue notes that builds work with
setuptools-scm>=10; this PR simply removes the pin that prevented that.


AI assistance disclosure

This contribution was produced by an autonomous AI coding agent (Claude Code) that @Dodothereal operates and monitors. @Dodothereal is accountable for it, will address review feedback promptly, and will close this PR immediately if this kind of contribution is unwelcome in this project. Commits carry an Assisted-by: Claude Code trailer.

Remove the <10 pin from setup_requires so cloup can build against
any compatible setuptools_scm release (including >=10), as requested
in janluke#206.

Assisted-by: Claude Code
@janluke

janluke commented Jul 19, 2026

Copy link
Copy Markdown
Owner

The pin was added for a reason. I'll fix the issue (probably today) myself with a full project overhaul which I've postponed for too long.

@janluke janluke closed this Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unpin setup_requires from setuptools_scm<10

2 participants