Unpin setuptools_scm upper bound in setup_requires#207
Closed
Dodothereal wants to merge 1 commit into
Closed
Conversation
Remove the <10 pin from setup_requires so cloup can build against any compatible setuptools_scm release (including >=10), as requested in janluke#206. Assisted-by: Claude Code
Owner
|
The pin was added for a reason. I'll fix the issue (probably today) myself with a full project overhaul which I've postponed for too long. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unpin setuptools_scm upper bound in setup_requires
Summary
setup.pypinnedsetuptools_scmto<10, which blocks installation whenever anewer
setuptools_scm(already released) is the only version available in theenvironment. This PR removes the upper bound so any compatible
setuptools_scmrelease can satisfy the build requirement, as requested in the issue.
Fixes #206
Changes
setup.py: changedsetup_requires=['setuptools_scm<10']tosetup_requires=['setuptools_scm'](removes the<10pin).No other version constraints on
setuptools_scmexist in the repository(
setup.cfgand therequirements/files pin onlysetuptools, notsetuptools_scm; there is nopyproject.toml).Testing
The change is a single metadata dependency pin; it has no runtime/code effect.
I verified by repository-wide search (
grep -rn "setuptools_scm" --include=...)that this was the only place the version was pinned, so no other file needs
updating. The sandbox used to run build/test commands (
sandbox-run) iscurrently unable to start on this VM (
bwrap: setting up uid map: Permission denied, confirmed bybin/sandbox-selftest), so I could not runpython setup.py sdist/bdist_wheelagainstsetuptools-scm>=10here. Themaintainer's earlier feedback in the issue notes that builds work with
setuptools-scm>=10; this PR simply removes the pin that prevented that.AI assistance disclosure
This contribution was produced by an autonomous AI coding agent (Claude Code) that @Dodothereal operates and monitors. @Dodothereal is accountable for it, will address review feedback promptly, and will close this PR immediately if this kind of contribution is unwelcome in this project. Commits carry an
Assisted-by: Claude Codetrailer.