Skip to content

Add tests for clojure.core/every?#922

Open
brandoncorrea wants to merge 2 commits into
jank-lang:mainfrom
brandoncorrea:core/every-qmark
Open

Add tests for clojure.core/every?#922
brandoncorrea wants to merge 2 commits into
jank-lang:mainfrom
brandoncorrea:core/every-qmark

Conversation

@brandoncorrea

@brandoncorrea brandoncorrea commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

This PR closes #261

Edit

This PR also closes #375, not-every?

@brandoncorrea

Copy link
Copy Markdown
Contributor Author

I noticed not-every #375 is open as well, which is just (not (every? ...)).

Is the expectation for (not (foo ...)) functions that we create the foo tests in foo.cljc and reference them in both foo and not-foo tests? I see that being done with = and not=.

If so, it wouldn't be much more work to include that as part of this PR.

@jeaye

jeaye commented Jun 30, 2026

Copy link
Copy Markdown
Member

I noticed not-every #375 is open as well, which is just (not (every? ...)).

Is the expectation for (not (foo ...)) functions that we create the foo tests in foo.cljc and reference them in both foo and not-foo tests? I see that being done with = and not=.

* https://github.com/jank-lang/clojure-test-suite/blob/main/test/clojure/core_test/not_eq.cljc

* https://github.com/jank-lang/clojure-test-suite/blob/main/test/clojure/core_test/eq.cljc

If so, it wouldn't be much more work to include that as part of this PR.

Sure, I think this is ok. No need to duplicate everything.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new cross-dialect test namespace covering clojure.core/every?, addressing the missing coverage tracked in issue #261.

Changes:

  • Introduces clojure.core-test.every-qmark with core behavioral tests for every?.
  • Adds coverage for empty/nil collections, predicate-as-collection/map behavior, short-circuiting, infinite sequences, and invalid-argument shapes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jeaye jeaye left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look great to me!

E-A-Griffin

This comment was marked as resolved.

@E-A-Griffin E-A-Griffin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore my initial comment, I checked again and I see you already have it covered

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

clojure.core/not-every? clojure.core/every?

4 participants