Added User-Agent header and code to dynamically generate new Sec-WebSocket-Key and verify Sec-WebSocket-Accept - #2
Open
zhiyong-ft wants to merge 7 commits into
Open
Conversation
To allow occasional ping-pong out of sync in case unstable uplinks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per discussion on StackOverflow, Sec-WebSocket-Key better be random and different for each new connection, that is how Sec-WebSocket-Key is implemented in mainstream WS client such as lws.
Also added is User-Agent header. It is customary and can also be useful to report this to server.
Hope these two features will make this library one step closer to be production ready.