Notify publish to Slack via centralized reusable workflow#14
Merged
Conversation
Removes per-repo .postpublish.sh and npm postpublish hook in favor of the janis-commerce/.github reusable workflow. Fixes the broken Slack notification (SLACK_WEBHOOK was never wired into the publish workflow). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qué
Migra la notificación de publish a Slack al reusable workflow centralizado `janis-commerce/.github/.github/workflows/slack-notify-publish.yml`.
Por qué
La notificación de Slack de este package estaba rota: tenía el `.postpublish.sh` y el hook npm, pero el workflow nunca mapeaba `SLACK_WEBHOOK`, así que el hook hacía `exit` sin notificar nunca. Ahora el secret se pasa explícito al reusable workflow.
Depende de janis-commerce/.github#1 (el reusable workflow). Mergear ese PR primero — si no, el job `notify-slack` falla con "workflow not found" en el próximo release.
🤖 Generated with Claude Code