Prep for step-reversing protocols - #59
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Extend
wait.waitableand stream backends to support “direction switching” readiness, where an operation can block on either readability or writability depending on the underlying state machine (eg. TLS WANT_READ/WANT_WRITE).Changes:
wait.waitable: allowstep()to returnfalse, want(want is any of'rd'|'wr'|'any'), passwantintoregister(), and re-register on each wake-up based on the latestwant.wait.waitable: supportwant == 'any'by registering both read + write waiters and unlinking both on completion/abort.io.stream: plumbwantfrom backendread_string/write_stringintowaitableand register on the appropriate readiness (on_readable/on_writable) depending onwant.fd_backend(posix/nixio/ffi): returnwanton EAGAIN/EWOULDBLOCK ('rd'for reads,'wr'for writes).fibers.scopedebug traceback capture in03-scope-finalisers.luato aid diagnosis during integration.Rationale:
Manual test
Manual test description
wantvalue and re-registers appropriately.want == 'any'handling by ensuring both registrations are created and unlinked as expected.Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
Nope