Update primitives - #55
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Tightens channel rendezvous semantics and makes waitgroups reusable; trims flakiness in tests.
channel.lua
on_abortto mark losing arms cancelled;pop_active()skips cancelled entries.waitgroup.lua
add()from zero, signal on return to zero.wait_op()rechecks aftertry()and blocks on the current generation only.tests
test_channel: assertget()blocks before supplying a value.test_waitgroup: add reuse test; shorten sleeps and timings to reduce runtime; adjust assertions accordingly.Net effect: correct choice-loss cleanup on channels, waitgroups that can be reused safely, fewer retained waiters, and faster, more deterministic tests.
Manual test
Manual test description
Exercised channel put/get across buffered and unbuffered cases; verified blocked
get()unblocks on subsequentput(). Verified waitgroup reuse across multiple generations; confirmed no deadlocks and expected wakeups.Added tests?
Added to documentation?