guard and with_nack first-class CML events - #51
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Converts the operation layer to first-class CML events and simplifies dependants.
Key changes:
fibers.op: reworked around anEventtype with primitive leaves,choice,guard,with_nack, andwrap. Addspoll()andperform_alt(); introduces a compiled synchronisation path and correct nack signalling for losing arms. Exposesnew_cond()as a one-shot signal-all primitive.fibers.cond: reduced to a thin wrapper overop.new_cond()(one-shot, signal-all semantics).fibers.waitgroup: now usesop.new_cond()directly; simplifiedwait_op()blocking.tests/test_op.luawith comprehensive coverage of base ops, choices, wraps, guards,with_nack(including nested cases),poll(), andperform_alt().This passes the full test suite.
Related Issues, Tickets & Documents
None.
Screenshots/Recordings
Not applicable.
Manual test
Manual test description
Ran the full suite locally; exercised new
opbehaviours (guards, nacks, poll) and confirmed expected outcomes.Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
None.