Skip to content

modify shutil for replacing duplicates - #4

Open
horphi0815 wants to merge 1 commit into
jan25:masterfrom
horphi0815:patch-2
Open

horphi0815 wants to merge 1 commit into
jan25:masterfrom
horphi0815:patch-2

Conversation

@horphi0815

Copy link
Copy Markdown

No description provided.

@jan25

jan25 commented Jul 25, 2020

Copy link
Copy Markdown
Owner

Hi @horphi0815. Thanks for the PR.

This change will break the base functionality of moving files. Perhaps the change needs to use different function from shutil package. Also, there are tests if you like to make sure base function is not broken, i'd also suggest to add a new test case to test your fix the #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants