Remove "wc -l" from Jamulus.pro

[pljones]

Short description of changes

Currently, to get a build number for android builds, Jamulus.pro runs wc -l -- this is unlikely to work on Windows and isn't necessary to achieve the result intended. This patch amends Jamulus.pro to use built-ins to do the calculation.

It also amends the build number so it is aways zero on dev builds. This is so that only tagged builds have the number of commits counted. (We're unlikely to have more commits on a release branch than on main.)

CHANGELOG: SKIP

Context: Fixes an issue?

Makes Jamulus.pro more portable.

Does this change need documentation? What needs to be documented and how?

No.

Status of this Pull Request

Tested locally, including on branch and tagged builds.

What is missing until this pull request can be merged?

Should be good, subject to review.

Checklist

• I've verified that this Pull Request follows the general code principles
• I tested my code and it does what I want
• My code follows the style guide
• I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
• I've filled all the content above

[Copilot]

Pull request overview

This PR updates the QMake project (Jamulus.pro) to make Android ANDROID_VERSION_CODE generation more portable (avoiding wc -l, which is not reliably available on Windows) and to force ANDROID_VERSION_CODE to 0 for *dev* builds.

Changes:

• Replace git log ... | wc -l with a QMake-based commit-count computation using $$system(..., lines) plus $$list()/$$size().
• Set ANDROID_VERSION_CODE = 0 by default and only compute a commit-count-based version code for non-dev versions when a .git/config is present.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

[mcfnord]

🤖 AI: Two checks on this, run with Qt 5.15.13 qmake on Linux:

• git rev-list --count HEAD and git log --oneline | wc -l agree — both 6419 on current main.
• In a git worktree checkout, .git is a file rather than a directory, so exists(".git/config") is false and a non-dev build from a worktree silently gets ANDROID_VERSION_CODE = 0. exists(".git") behaves as intended in both layouts, since qmake's exists() matches files as well as directories.

A shadow build with the build directory outside the repository is unaffected either way: qmake resolves both exists() and $$system() against the source directory.

[pljones]

a non-dev build from a worktree

Mmm. Does that include the Github autobuild workflow? I think that does git clone. The aim is that zero should appear anywhere that isn't a Github autobuild workflow for a release build, so the check wants to be as strict as possible, rather than in any way permissive.

[mcfnord]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Then probably just say nothing next time.

[ann0see]

Looks ok.

--
I think that it just needs to be an increasing number. As we don't publish it in the play store anyway (yet) how we calculate it does not matter.

[pljones]

Looks ok.

-- I think that it just needs to be an increasing number. As we don't publish it in the play store anyway (yet) how we calculate it does not matter.

Yep - this was part of what I was doing after 3.11.0 to get 3.12.0 ready for Play Store (but I was using Windows Qt Creator at the time, hence the build failing on the wc -l).

[pljones]

Closing - will merge this into a larger rewrite.