Skip to content
This repository was archived by the owner on Aug 6, 2025. It is now read-only.

Main - #47

Draft
DarkmoonThomas wants to merge 1 commit into
jamincollins:mainfrom
DarkmoonThomas:main
Draft

Main#47
DarkmoonThomas wants to merge 1 commit into
jamincollins:mainfrom
DarkmoonThomas:main

Conversation

@DarkmoonThomas

Copy link
Copy Markdown

Added gcode_macro to features, including a readme, install.sh and the gcode_macro.cfg. Modified gcode_macro.cfg includes AMP (adaptive purge line). PLEASE look these over extremely close, I have no idea if my coding is correct on the install.sh

Modified start_print.cfg to include AMP. It is commented out, so the user will have to add start_pring.cfg to their overrides.cfg and uncomment if they opt to use it.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to create a new file with just the bit needed. No need to copy all the other macros.

@@ -0,0 +1,25 @@
# START_PRINT

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be named for the feature it's documenting.

Comment on lines +13 to +14
ln -sf ${SCRIPT_DIR}/start_print.cfg \
~/printer_data/config/gcode_macro.cfg

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be creating a file in the custom folder rather than replacing an existing Creality file.

Comment on lines +145 to +146
# Call AMP macro with MINX and MINY values passed from slicer. Uncomment the line below if adaptive purge is desired.
# AMP MINX={MINX} MINY={MINY}

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this I'd create a new variable in the VARS macro and use it as a conditional. So that users can enable this if they'd like.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not gonna lie, you completely lost me here.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@txt4nk I'm not sure what you don't understand so forgive this explanation if that's not what your confused about. he saying uncomment that line, assign it to a variable that you create so it's easier for the user to configure. You can do this in the VARS macro, you can add it here:

[gcode_macro _START_PRINT_VARS]

@DarkmoonThomas
DarkmoonThomas marked this pull request as draft March 17, 2025 02:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants