Add dmesg based disk selection - #71
Conversation
There was a problem hiding this comment.
Code Review
This pull request replaces hardcoded disk and volume candidates with dynamic discovery logic in the Samba startup script and the Python probing module. The discovery process uses dmesg and sysctl to identify disk wedges while filtering out metadata. Review feedback highlights performance inefficiencies in the discovery logic, specifically the overhead of repeated dmesg calls within loops, and suggests optimizing helper functions to reuse pre-calculated disk lists.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request replaces hardcoded disk device candidates with a dynamic discovery mechanism that identifies HFS disk wedges using dmesg and sysctl. The changes include new shell functions for filtering data partitions and excluding configuration or swap wedges, which are integrated into both the Samba boot script and the Python probe module. Review feedback correctly identified a potential issue where newline-separated device names could break shell pattern matching in case statements, and suggested normalizing these into space-separated strings.
… device name preceded by a newline instead of a space.
No description provided.