Skip to content

Update Class - Slider.lua - #4

Open
mespotine wants to merge 1 commit into
jalovatt:masterfrom
mespotine:slider-class-has-internal-variable-_-exposed
Open

Update Class - Slider.lua#4
mespotine wants to merge 1 commit into
jalovatt:masterfrom
mespotine:slider-class-has-internal-variable-_-exposed

Conversation

@mespotine

Copy link
Copy Markdown
Collaborator

localized internal variable _

I don't think, it had a negative impact, but nevertheless, I localized it, to be safe.

localized internal variable _

I don't think, it had a negative impact, but nevertheless, I localized it, to be safe.
@mespotine
mespotine requested a review from jalovatt as a code owner June 23, 2020 22:56
@jalovatt

jalovatt commented Jun 24, 2020

Copy link
Copy Markdown
Owner

I just tried in the Lua command line and I think the _ = is actually unnecessary for performing a conditional operation like this - those might all be able to just do:

self.horz and gfx.circle(min, y + (h / 2), h / 2 - 1, 1, 1)
          or  gfx.circle(y + (h / 2), min, h / 2 - 1, 1, 1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants