Fix locale-sensitive post_mod coordinate parsing#20
Open
dmerkle wants to merge 1 commit into
Open
Conversation
1b2be2b to
3dcbc8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix PostMØD's Graphviz
.plainparsing so coordinate dimensions are interpreted with the C locale.Under locales such as
de_DE.UTF-8, the size check for Graphviz output can misclassify small figures as too large. For example, a graph line likegraph 1 3.1224 3.2197can trigger the\dontUseTooLargeCoordsfallback, causing summaries to showFigure too largeeven though the DG is small enough to embed.This change runs the relevant
awkparsers withLC_ALL=Cwhile leaving the surrounding environment unchanged.Validation
Locally reproduced the false fallback under
LC_ALL=de_DE.UTF-8with a small derivation graph, then verified the patchedmod_postno longer emits\dontUseTooLargeCoordsand the summary embeds the DG correctly under bothde_DE.UTF-8andC.UTF-8.