Add minimal CI - #2
Merged
Merged
Conversation
Runs the pytest suite on Python 3.11 and 3.12 plus a compile check, with a ci-ok gate job. No package install step since the plugin has no pyproject and needs no pip packages beyond pytest. Claude-Session: https://claude.ai/code/session_01K1ic1eRNwFgm5re6gANPMZ
jagmarques
marked this pull request as ready for review
July 9, 2026 13:39
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the first CI workflow. The repo had none.
What it does:
No package install step. The plugin ships as hook scripts with no pyproject
and no third-party runtime deps, so CI installs pytest and nothing else. No
ruff step either, since the repo carries no lint config to honor.
Tests run with python -m pytest so the repo root lands on sys.path and the
suite can import scripts.asqav_hook. The bare pytest console script cannot,
and one test fails under it.
Triggers on push and pull_request to main.
Proof of work
Local run before push (Python 3.11.15):
Live CI on this PR, run https://github.com/jagmarques/asqav-claude-code/actions/runs/29021952576 (conclusion success):
Both matrix legs installed pytest 9.1.1 and reported the full suite green:
Diff stat: 1 file changed, 34 insertions.