test(ansible): raise Go unit coverage for install methods and generator - #192
Merged
Conversation
Expand install method render tests to all InstallMethod implementations, add types helper coverage, and fixture-based tests for playbook dependency parsing and Qubes script generation. Coverage goes from ~26% to ~78%.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
devtools/setup-dev/ansiblefrom ~26% to ~78% statement coverage.InstallMethodimplementations (render output, imports, setup tasks, block variants), not justGoInstallMethod.indent,stripBlockAndIndent, GitHub release task rendering, become/environment).types_test.gofor package/tool defaults,CommandID, platform helpers, and factory constructors.generate_packages_test.gofor playbook import/include parsing, dependency graphs, BUILD rule generation, GPG key setup, and Qubes TemplateVM script generation.Test plan
go test -cover ./...indevtools/setup-dev/ansible(~78% coverage)make check(format, lint, bazel tests, semgrep, bazel Go file check)