Add icons to Project navbar menu and footer links#1116
Merged
yurishkuro merged 6 commits intoJul 9, 2026
Conversation
Replace the plain text entries in the Project dropdown with Font Awesome icons (monochrome, matching the existing GitHub/social icons) and swap the boxed bullet glyph on the mentorship sub-items for a plain bullet character. Signed-off-by: Yuri Shkuro <github@ysh.us>
Render an optional trailing icon after each link in the footer's "Get in touch" list, matching the icon style used elsewhere in the navbar and footer. Signed-off-by: Yuri Shkuro <github@ysh.us>
yurishkuro
changed the title
There was a problem hiding this comment.
Pull request overview
This PR updates Jaeger’s Hugo/Docsy theme overrides and site configuration to add Font Awesome icons to “Project” navigation items and the footer “Get in touch” links, while also normalizing the mentorship submenu bullet rendering across platforms.
Changes:
- Add trailing Font Awesome icons to footer “Get in touch” links via a new optional
iconfield inparams.links.developer. - Add leading Font Awesome icons to entries in the “Project” navbar dropdown using Hugo menu
preHTML. - Replace the boxed bullet glyph (⏺) with a plain bullet (•) for the “For Mentees” / “For Mentors” submenu items.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| themes/docsy-overrides/layouts/_partials/footer/list.html | Renders optional per-link icons in the footer “Get in touch” list. |
| hugo.yaml | Adds icon metadata for footer links and menu pre HTML for Project navbar entries; adjusts mentorship submenu bullet glyph. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Use params.icon on Project navbar menu entries instead of raw <i> markup in pre, mirroring the icon field already used for the footer links. Mute both the navbar icons and the mentorship sub-item dash with Bootstrap's opacity-50, matching the light/dark theme toggler. Signed-off-by: Yuri Shkuro <github@ysh.us>
fa-fw assumes icons render at ~1.25em, but fa-handshake and fa-comments use a 640x512 viewBox and overflow that box, leaving no visible gap before the label no matter how much padding is added. Replace fa-fw with a wider, clipped custom box so every icon aligns consistently regardless of its native aspect ratio. Signed-off-by: Yuri Shkuro <github@ysh.us>
Flow-style mappings (params: {...}) were only used on the new menu
entries added in this branch; every other mapping in hugo.yaml is
block-style. Match the file's existing convention.
Signed-off-by: Yuri Shkuro <github@ysh.us>
The template had both a literal space and a ps-1 padding class before the icon, stacking two gaps instead of one. Signed-off-by: Yuri Shkuro <github@ysh.us>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
params.iconmenu param (consistent with theiconfield already used for footer links) instead of raw markup inpre.opacity-50, matching the light/dark theme toggler's icon style.fa-handshake,fa-comments) use a wider viewBox than most others and overflowed Font Awesome's own.fa-fwfixed-width box, leaving no visible gap before the label. Added a custom, wider, clipped icon box so alignment is consistent regardless of a given icon's native aspect ratio.Test plan
hugo serverlocally and confirmed each icon renders correctly in the Project dropdown