Skip to content

fix: fix favorites command not working - #61

Open
ingjieye wants to merge 1 commit into
jackwener:mainfrom
ingjieye:fix/favorites-browser-fallback
Open

fix: fix favorites command not working#61
ingjieye wants to merge 1 commit into
jackwener:mainfrom
ingjieye:fix/favorites-browser-fallback

Conversation

@ingjieye

@ingjieye ingjieye commented Jun 9, 2026

Copy link
Copy Markdown

Summary

  • Fix xhs favorites failing when the current web signing flow rejects the direct API request
  • Update the favorites request parameters to match the current web API shape
  • Use the existing Camoufox browser fallback in this project to capture the real web API response when signed requests fail
  • Wrap Camoufox startup and page-driving failures in project-level exceptions
  • Add regression tests for request parameters, fallback triggers, Camoufox backend usage, and fallback failure handling

Verification

  • uv run --extra dev ruff check xhs_cli/client_mixins.py tests/test_client.py
  • uv run --extra dev pytest -q
  • uv run xhs favorites --json

Notes

  • The browser fallback uses the existing Camoufox runtime in this project and does not hard-code a local Chrome executable path.

@ingjieye ingjieye changed the title fix: add browser fallback for favorites fix: 修复 favorites 不能用 Jun 9, 2026
@ingjieye ingjieye changed the title fix: 修复 favorites 不能用 fix: fix favorites command not working Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant