Skip to content

Replace Alert dialogs with Toast notifications and fix safe area - #22

Merged
jacklevin74 merged 1 commit into
masterfrom
safe-area-fix
Nov 17, 2025
Merged

Replace Alert dialogs with Toast notifications and fix safe area#22
jacklevin74 merged 1 commit into
masterfrom
safe-area-fix

Conversation

@stackedPenguin

Copy link
Copy Markdown
Collaborator

Summary

  • Replace all 37 Alert.alert() calls with elegant Toast.show() notifications
  • Fix bottom navigation safe area padding for devices with notches/gesture bars
  • Simplify confirmation dialogs to execute directly with toast feedback
  • Improve user experience with consistent, non-blocking toast notifications

Changes Made

Toast Notifications (37 replacements)

Transaction Alerts (1)

  • Transaction success confirmation → Success toast

Wallet Management (8)

  • Wallet deletion success/errors
  • Duplicate wallet warnings
  • Import/create wallet errors
  • Seed phrase validation errors

Ledger Connection (11)

  • Bluetooth permissions
  • Setup instructions
  • Scan/connection errors
  • USB connection errors
  • Device pairing/forgetting

Settings & Preferences (5)

  • Network connection errors
  • Preferences info
  • About wallet info
  • Reset wallet
  • Clear PIN & biometrics

Confirmation Dialogs → Direct Actions (12)

  • All confirmation dialogs now execute directly with toast feedback
  • Examples: delete wallet, reset wallet, forget device, clear PIN, change seed phrase

Safe Area Fix

✅ Wrapped app with SafeAreaProvider
✅ Added useSafeAreaInsets() hook
✅ Updated bottom navigation to use dynamic padding
✅ Removed hardcoded padding values

Technical Details

  • Removed Alert import from react-native
  • Consistent toast patterns:
    • type: "success" for successful operations
    • type: "error" for errors
    • type: "info" for informational messages
    • position: "bottom" for all toasts

Test Plan

  • Transaction complete shows success toast
  • Wallet operations show appropriate toasts
  • Ledger connection errors show error toasts
  • Settings actions show feedback toasts
  • Bottom navigation padding adapts to device safe areas
  • No Alert dialogs remain in the app

Generated with Claude Code

- Replace 37 Alert.alert() calls with Toast.show() notifications
- Remove Alert import from react-native
- Update transaction success notifications to use Toast
- Convert wallet management alerts (create, import, delete, duplicate) to Toasts
- Replace Ledger connection/pairing alerts with Toast notifications
- Update settings alerts (preferences, reset, clear PIN) to use Toasts
- Simplify confirmation dialogs to execute directly with toast feedback
- Maintain consistent toast patterns (success/error/info types, bottom position)
- Fix bottom navigation safe area padding

Generated with Claude Code

Co-Authored-By: Claude <noreply@anthropic.com>
@jacklevin74
jacklevin74 merged commit b0c592b into master Nov 17, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants