Skip to content

Add custom app icons and fix bottom navigation safe area - #19

Closed
stackedPenguin wants to merge 1 commit into
masterfrom
feat/add-custom-app-icons-fix-safe-area
Closed

Add custom app icons and fix bottom navigation safe area#19
stackedPenguin wants to merge 1 commit into
masterfrom
feat/add-custom-app-icons-fix-safe-area

Conversation

@stackedPenguin

Copy link
Copy Markdown
Collaborator

Summary

  • Added custom launcher icons from AppIcons source for all density variants
  • Upgraded safe area context package and fixed bottom navigation overlapping issue
  • Updated .gitignore to properly track app icon resources

Changes Made

App Icons

  • Added ic_launcher.png and ic_launcher_round.png for all densities (hdpi, mdpi, xhdpi, xxhdpi, xxxhdpi)
  • Removed adaptive icon XMLs and webp files to ensure PNG icons are used directly
  • Updated .gitignore to selectively track android/app/src/main/res/mipmap-*/ directories

Safe Area Context Fix

  • Replaced react-native-safe-area-context with updated version from @AppAndFlow/react-native-safe-area-context
  • Implemented useSafeAreaInsets hook in AppContent component
  • Applied dynamic padding to bottom navigation bar based on device safe area insets
  • Removed hardcoded padding values that were causing overlap on devices with gesture navigation

Testing

  • Built release APK and tested on Android emulator
  • Verified custom icons appear correctly in launcher and app drawer
  • Confirmed bottom navigation no longer overlaps with system navigation bar
  • Tested on devices with gesture navigation

🤖 Generated with Claude Code

- Add custom launcher icons from AppIcons source
  - Added ic_launcher.png and ic_launcher_round.png for all densities
  - Removed adaptive icon XMLs and webp files to use PNG icons directly

- Replace safe area context with updated version
  - Installed react-native-safe-area-context from @AppAndFlow/react-native-safe-area-context
  - Implemented useSafeAreaInsets hook in bottom navigation
  - Fixed bottom tab bar overlapping with system UI on devices with gesture navigation

- Update .gitignore to track app icon resources
  - Configured selective tracking of android/app/src/main/res/mipmap-*/ directories
  - Ensures custom app icons are version controlled

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@stackedPenguin

Copy link
Copy Markdown
Collaborator Author

Will include in next PR

stackedPenguin pushed a commit that referenced this pull request Nov 17, 2025
Merged changes from feat/add-custom-app-icons-fix-safe-area:
- Added custom launcher icons (PNG format) for all density variants
- Upgraded safe area context package for better bottom navigation handling
- Updated .gitignore to track both AndroidManifest.xml and app icons

Resolved conflicts in .gitignore by combining both approaches:
- Track AndroidManifest.xml for cleartext traffic configuration
- Track mipmap-*/ directories for custom app icons
@stackedPenguin
stackedPenguin deleted the feat/add-custom-app-icons-fix-safe-area branch November 17, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants