Wallet modal improvements and Android package configuration - #13
Merged
Conversation
Changes: - Keep @gorhom/bottom-sheet imports (native modules still compile) - Override with dummy components that don't render - Add network timeout fix (3s) for SOL price fetching - Add reanimated import as first line in index.js This test version allows isolating whether bottom sheet animations are causing UI freezes on certain devices. All functionality works except bottom sheet UI won't be visible. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Replaced worklets/reanimated-based bottom sheets with simple Modal components to eliminate UI freezing issues on certain devices. Changes: - Created SimpleBottomSheet.tsx using React Native Modal - Removed @gorhom/bottom-sheet dependency from App.js - All bottom sheets now use Modal with slide animation - Network timeout fix (3s) for SOL price fetching - Reanimated import as first line in index.js Benefits: - No UI freezes (no worklets/reanimated animations) - Works with both Hermes and JSC - Simpler, more reliable bottom sheet implementation - All functionality preserved 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Migrate from React Navigation to @lodev09/react-native-true-sheet to eliminate navigation flashing and improve performance with native bottom sheet animations. Changes: - Add TrueSheet package and remove React Navigation dependencies - Extract all navigation screens to dedicated screen files: - SendScreen.js - Send token transactions - ReceiveScreen.js - Display QR code and address - ActivityScreen.js - Transaction history - WalletManagerScreen.js - Wallet selection and management - WalletSettingsScreen.js - Wallet edit options - AddressSelectorScreen.js - Address picker for send flow - Convert navigation.navigate() to ref-based sheet.present() calls - Replace route.params with direct prop passing - Remove SafeAreaView (handled by TrueSheet internally) - Implement nested sheet support (SendScreen -> AddressSelector) Benefits: - Smoother, native bottom sheet animations - Eliminates navigation fade flashing - Better performance with imperative API - Cleaner component architecture
- Auto-select and scroll to current wallet when wallet modal opens - Auto-expand wallet modal to full screen when more than 2 wallets exist - Auto-select newly created wallet after wallet creation - Register new wallets with transaction indexer - Add TrueSheet configuration with proper sizes and styling for all modals - Extract Ledger connection screen into separate component 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds several wallet modal UX improvements and updates the Android package configuration:
xyz.x1.walletand app name toX1 WalletTechnical Details
Wallet Modal Improvements
useEffecthook inWalletManagerScreento auto-scroll to selected wallet usingmeasureLayoutandscrollToselected: trueon new wallets and deselect otherswalletManagerSheetRef.current?.resize(1)when wallet count > 2Android Configuration
android/android/app/build.gradlenamespace and applicationId toxyz.x1.walletandroid/android/app/src/main/res/values/strings.xmlapp_name toX1 WalletTest Plan
xyz.x1.wallet) and app name (X1 Wallet)Build Info
APK Location:
android/android/app/build/outputs/apk/release/app-release.apkSize: 37 MB
Package:
xyz.x1.walletVersion: 1.0.0
🤖 Generated with Claude Code