Fix: Prevent extension breakage when exiting wallet setup halfway

[stackedPenguin]

Problem

When users exited halfway through wallet setup and reopened the extension popup, the extension would break with:

• ❌ Black screen flickering
• ❌ Infinite loading spinner
• ❌ Unusable popup
• ❌ No way to complete setup or access the extension

Root Cause

The issue had multiple contributing factors:

1. No cleanup of incomplete state - Partial wallet setup data remained in localStorage
2. Poor loading state handling - RequireUserUnlocked returned null causing black screen
3. Race conditions - Opening new popup while closing current one caused flickering
4. Wrong redirect destination - Initially redirected to popup.html which has no onboarding routing
5. Wrong window type - Opened as popup instead of full tab like first install

Solution

1. Automatic State Cleanup

File: packages/secure-background/src/store/SecureStore.ts

Added cleanupIncompleteOnboarding() method that:

• Detects when user data exists but encrypted keyring (ciphertext) or public keys are missing
• Automatically cleans up partial data via this.reset()
• Returns true if cleanup occurred

2. Integrated Auto-Cleanup

File: packages/secure-background/src/store/KeyringStore/KeyringStore.ts

Modified state() method to call cleanupIncompleteOnboarding() before returning NeedsOnboarding state, ensuring cleanup happens automatically before UI renders.

3. Fixed Loading State & Tab Opening

File: packages/secure-ui/src/RequireUserUnlocked/RequireUserUnlocked.tsx

Changes:

• Show <Loading /> component instead of null (which caused black screen)
• Open options.html?onboarding=true in full browser tab (not popup)
• Close popup window after tab opens
• Matches first install behavior exactly

How It Works Now

Before (Broken):

1. User exits halfway → partial data in storage
2. User reopens → loads with incomplete state
3. RequireUserUnlocked returns null → black screen
4. Race conditions → flickering
5. Extension stuck/broken

After (Fixed):

1. User exits halfway → partial data in storage
2. User reopens → popup loads
3. Auto-cleanup runs → clears incomplete state
4. Shows loading spinner → smooth UX
5. Opens onboarding in full tab → exactly like first install
6. Works perfectly ✅

Testing

1. Load extension and start wallet setup
2. Exit halfway through (after entering name, before password)
3. Reopen the popup
4. ✅ Brief loading spinner appears
5. ✅ Full tab opens with onboarding screen
6. ✅ Complete wallet setup successfully

Files Changed

• packages/secure-background/src/store/SecureStore.ts - Added cleanup method
• packages/secure-background/src/store/KeyringStore/KeyringStore.ts - Integrated cleanup
• packages/secure-ui/src/RequireUserUnlocked/RequireUserUnlocked.tsx - Fixed loading & tab opening
• yarn.lock - Updated dependencies

🤖 Generated with Claude Code

[jacklevin74]

Integrated via cherry-pick in 895e8de. See ONBOARDING_FIXES.md