fix: cursor pagination on events index repeating same rows - #47
Merged
Conversation
The Flop schema sorted on `[:inserted_at, :id]` but `search_events/2` selected a partial field list that did not include `inserted_at`. The extracted cursor therefore had `inserted_at: nil`, which Flop's Ecto adapter drops, leaving only `id > cursor_id` as the cursor predicate. Combined with the manually-prepended `order_by(desc: timestamp)` (which Flop was already warning about), each "Next" click peeled one record off the bottom of the same set instead of advancing. Have Flop own the ordering and base the cursor on `[:timestamp, :id]` — both already in the SELECT — and replace the leftover `(timestamp, inserted_at, id)` index with a `(timestamp, id)` one that matches the new ORDER BY. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Flop schema sorted on
[:inserted_at, :id]butsearch_events/2selected a partial field list that did not includeinserted_at. The extracted cursor therefore hadinserted_at: nil, which Flop's Ecto adapter drops, leaving onlyid > cursor_idas the cursor predicate. Combined with the manually-prependedorder_by(desc: timestamp)(which Flop was already warning about), each "Next" click peeled one record off the bottom of the same set instead of advancing.Have Flop own the ordering and base the cursor on
[:timestamp, :id]— both already in the SELECT — and replace the leftover(timestamp, inserted_at, id)index with a(timestamp, id)one that matches the new ORDER BY.