test: add build diagnostic metadata tests #42
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -234,6 +234,28 @@ async function request<T>( | |
| const response = await fetch(requestConfig.url, requestConfig); | ||
| clearTimeout(timeoutId); | ||
|
|
||
| // --- FIX: Normalize non-2xx responses into ApiError --- | ||
| if (!response.ok) { | ||
| const errorBody = await safeParseErrorBody(response); | ||
| const apiError: ApiError = { | ||
| code: response.status, | ||
| message: errorBody.message || response.statusText || 'Request failed', | ||
| details: errorBody.details, | ||
| requestId: response.headers.get('X-Request-ID') || undefined, | ||
| path: path, | ||
| suggestion: errorBody.suggestion || getDefaultSuggestion(response.status), | ||
| }; | ||
|
|
||
| // Run through error interceptor chain | ||
| let processedError = apiError; | ||
| for (const interceptor of errorInterceptors) { | ||
| processedError = interceptor(processedError); | ||
| } | ||
|
|
||
| throw processedError; | ||
| } | ||
| // --- END FIX --- | ||
|
|
||
| const responseData = await parseResponse<T>(response); | ||
|
|
||
| // Apply response interceptors | ||
|
|
@@ -244,6 +266,14 @@ async function request<T>( | |
|
|
||
| return apiResponse; | ||
| } catch (error) { | ||
| // If already an ApiError (from non-2xx handling above), re-throw immediately. | ||
| // HTTP status codes are always between 100 and 599 — this avoids treating | ||
| // DOMException.code (e.g. ABORT_ERR = 20) as an HTTP status. | ||
| const errCode = (error as any)?.code; | ||
| if (typeof errCode === 'number' && errCode >= 100 && errCode < 600) { | ||
| throw error; | ||
| } | ||
|
|
||
| lastError = error as Error; | ||
|
|
||
| if (attempt < maxRetries && method === 'GET') { | ||
|
|
@@ -265,6 +295,60 @@ async function request<T>( | |
| throw processedError; | ||
| } | ||
|
|
||
| /** | ||
| * Safely parse an error response body into structured fields. | ||
| * Handles JSON error bodies, text errors, and empty responses. | ||
| */ | ||
| async function safeParseErrorBody(response: Response): Promise<{ | ||
| message?: string; | ||
| details?: Record<string, unknown>; | ||
| suggestion?: string; | ||
| }> { | ||
| const contentType = response.headers.get('content-type') || ''; | ||
| const cloned = response.clone(); | ||
|
|
||
| try { | ||
| if (contentType.includes('application/json')) { | ||
| const body = await cloned.json(); | ||
| if (body && typeof body === 'object') { | ||
| return { | ||
| message: typeof body.message === 'string' ? body.message | ||
| : typeof body.error === 'string' ? body.error | ||
| : typeof body.error?.message === 'string' ? body.error.message | ||
| : undefined, | ||
| details: body.details || body.errors || undefined, | ||
| suggestion: typeof body.suggestion === 'string' ? body.suggestion : undefined, | ||
| }; | ||
| } | ||
| } | ||
| } catch { | ||
| // JSON parse failed, try as text | ||
| } | ||
|
|
||
| try { | ||
| const text = await cloned.text(); | ||
|
Comment on lines
+307
to
+329
There was a problem hiding this comment. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win 🧩 Analysis chain🌐 Web query:
💡 Result: The Fetch API's Response body is a stream that can be consumed only once [1][2][3]. When you call a method such as.json,.text, or.blob, the underlying stream is read to completion and then locked [4][5][2]. Regarding your specific scenario: If you create a clone of a Response using Response.clone before consuming it, you can successfully read the body of the clone independently [6][7]. However, if you attempt to call a second consumption method (like.text) on the same Response object (or the same clone) after a previous consumption method (like.json) has already initiated or completed, it will fail [1][8][2]. If the initial.json call fails due to a parsing error, the stream is still considered "used" or "locked" because the consumption process was already initiated [1][5]. Consequently, a subsequent.text call on that same object will still result in an error (typically a TypeError stating the stream is already read or locked) [1][8][9]. To read the data in multiple formats or to handle potential parse failures while retaining access to the raw body, the recommended approach is to clone the response before the first attempt to read it [1][6][7]. For example: const response = await fetch(url); const clone = response.clone; try { const data = await response.json; } catch (e) { // Parsing failed, but you can still read from the clone const rawText = await clone.text; console.error("JSON parse failed, raw body:", rawText); } Citations:
🏁 Script executed: #!/bin/bash
set -euo pipefail
FILE="frontend/src/services/api.ts"
# Show the relevant function with line numbers
wc -l "$FILE"
sed -n '280,360p' "$FILE" | cat -n
# Look for other body-reading patterns on Response in this file
rg -n "response\.clone\(\)|\.json\(\)|\.text\(\)|safeParseErrorBody" "$FILE"Repository: jackjin1997/TentOfTrials Length of output: 3769 🏁 Script executed: #!/bin/bash
set -euo pipefail
FILE="frontend/src/services/api.ts"
wc -l "$FILE"
sed -n '280,360p' "$FILE" | cat -n
rg -n "response\.clone\(\)|\.json\(\)|\.text\(\)|safeParseErrorBody" "$FILE"Repository: jackjin1997/TentOfTrials Length of output: 3769 Read the body into text before parsing JSON
🤖 Prompt for AI Agents |
||
| if (text) { | ||
| return { message: text }; | ||
| } | ||
| } catch { | ||
| // Text read failed | ||
| } | ||
|
|
||
| return {}; | ||
| } | ||
|
|
||
| /** | ||
| * Returns a user-facing suggestion based on the HTTP status code. | ||
| */ | ||
| function getDefaultSuggestion(status: number): string | undefined { | ||
| if (status === 401) return 'Your session may have expired. Please try logging in again.'; | ||
| if (status === 403) return 'You do not have permission to perform this action.'; | ||
| if (status === 404) return 'The requested resource was not found.'; | ||
| if (status === 429) return 'Too many requests. Please wait a moment and try again.'; | ||
| if (status >= 500) return 'The server encountered an error. Please try again later.'; | ||
| return undefined; | ||
| } | ||
|
|
||
| function buildUrl(path: string, params?: QueryParams): string { | ||
| const baseUrl = `${API_BASE_URL}${path.startsWith('/') ? path : `/${path}`}`; | ||
| if (!params) return baseUrl; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: jackjin1997/TentOfTrials
Length of output: 3966
🏁 Script executed:
Repository: jackjin1997/TentOfTrials
Length of output: 4789
Exclude the output bundle from preflight inputs and fail on pack errors.
preflight.logdsits underworkspace, so--include workspacecan pull the file being written into the pack; restore the non-zero return-code check so a partial.logdcan’t pass preflight.🧰 Tools
🪛 ast-grep (0.44.1)
[error] 237-251: Command coming from incoming request
Context: subprocess.run(
[
str(encryptly_bin),
"pack",
str(logd_path),
"--include",
str(workspace),
"--max-file-size",
"32000",
],
cwd=str(ROOT),
capture_output=True,
text=True,
timeout=timeout,
)
Note: [CWE-78] Improper Neutralization of Special Elements used in an OS Command ('OS Command Injection').
(subprocess-from-request)
🪛 Ruff (0.15.20)
[error] 238-238:
subprocesscall: check for execution of untrusted input(S603)
🤖 Prompt for AI Agents