Add WebSocket hub lifecycle tests#20
Conversation
|
Warning Review limit reached
More reviews will be available in 56 minutes and 10 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Add unit tests for the WebSocket server and hub, and resolve a concurrent map write panic in the broadcast delivery path when removing slow/full client channels.
Changes
RLock) inmarket/ws/server.go. Specifically:Hub.Run(), messages onh.broadcastare written to client buffers under anRLock.slowClientsslice.Lock) is acquired, and the slow clients are safely unregistered/deleted and their channels closed without causing map panic or concurrency races.market/ws/server_test.gowith Go unit tests verifying:build.py's_normalize_os()mapping to support Android/Termux environments.tools/encryptly/linux-arm64/encryptlywith a Python wrapper script to support compilation.diagnostic/.Testing
go test -v ./wsChecklist
/claim #1
Required validation
diagnostic/build-36b7be47.logddiagnostic/build-36b7be47.jsonencryptly unpack diagnostic/build-36b7be47.logd <outdir> --password 68086257577bc9c0f93d