made my search feature incoorporate the edit distance work#26
Open
jackdavidweber wants to merge 2 commits into
Open
made my search feature incoorporate the edit distance work#26jackdavidweber wants to merge 2 commits into
jackdavidweber wants to merge 2 commits into
Conversation
Danish21
approved these changes
Jun 22, 2020
| if(ed < maxED){ | ||
| retArray.push({"sentence": sentence, "editDistance": ed}); | ||
| retArray.push({"sentence": sentence, "editDistance": ed, "arrIndex": tracker}); | ||
| tracker += 1; |
| li[i].style.display = "none"; | ||
| } | ||
|
|
||
| const matches = distanceOfArr(stringArray, filter, 2) |
Collaborator
There was a problem hiding this comment.
Consider giving the user feedback that only one term is supported. Fine to just add a todo comment for now.
augerm
approved these changes
Jun 22, 2020
| const matches = distanceOfArr(stringArray, filter, 2) | ||
|
|
||
| // make matches re-appear | ||
| for (i=0; i < matches.length; i++){ |
Collaborator
There was a problem hiding this comment.
Or better for(let match of matches) { ... }
| } else { | ||
| li[i].style.display = "none"; | ||
| } | ||
| stringArray.push(txtValue.toUpperCase()); // FIXME: touppercase might not work |
Collaborator
There was a problem hiding this comment.
Update comment with might not work with toUpperCase() or remove.
| } | ||
| stringArray.push(txtValue.toUpperCase()); // FIXME: touppercase might not work | ||
|
|
||
| //set all of the list items to disapear so that they can be made to reapear later |
Collaborator
There was a problem hiding this comment.
nit: add spacing for consistancy // set
g-harel
approved these changes
Jun 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Realized that my portfolio never actually used the edit distance stuff I worked on. While I know that I still need to work on my algorithm a bit, I thought that I should connect it in the meantime as we move away from portfolio and onto capstone.