Conversation
shellcheck: - create_symlinks.sh: SC2046 quote $(pwd) - manage-platform.sh: SC2155 declare/assign separately, SC2207 use mapfile, SC2086 quote $0, SC2076 use glob instead of quoted regex, SC2162 read -r - platform-exec.sh: SC2086 quote $0 markdownlint: - WORKFLOW_GUIDE.md: MD040 add language to fenced block, MD034 wrap bare URLs - CLAUDE.md: MD040 add language to fenced block - IMPLEMENTATION_SUMMARY.md: MD040 add language to fenced blocks, MD024 rename duplicate heading - README.md: MD030 fix list marker spacing (3 spaces → 1) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
manage-platform.sh gains -i for layering a per-VM gitignored inventory on top of the base Proxmox inventory, replacing long -e flag chains. proxmox_vm create now sets cloud-init password (from VM_CI_PASS env var) and network bridge explicitly. proxmox_template moves cloud-init password to an env-var lookup (SSH_CI_PASS) instead of a hardcoded default, and switches debian12/13 templates to the non-cloud generic qcow2 images.
yamllint/markdownlint/ansible-lint were running with strict defaults since this collection never had config files, unlike sibling collections (e.g. solti-podman). Adopt the same incremental warn_list pattern. Also fix syntax-check to only scan playbooks/ instead of matching any file with "main" in the name (which caught role tasks/defaults/vars/meta files and always failed).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary