Add optional Rust accelerator for bidict - #375
Draft
jab wants to merge 18 commits into
Draft
Conversation
Make the Rust toolchain hermetic via nix and wire an optional PyO3 helper package into the development workflow. Add an initial native fast path for building dict-backed bidict state, along with tests and related ignore/doc updates. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Stop ignoring benchmark_linux_arm64.sh and add it to the repository as a local helper for running the existing cachegrind microbenchmark workflow on this Mac via a Linux container. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Tighten the Linux benchmark helper to use a pinned modern Rust image and extend the optional native helper to accelerate rollback-safe bulk updates into existing dict-backed bidicts. Add coverage for the new update path and inverse-preservation behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Allow the optional native helper import to be disabled via BIDICT_DISABLE_NATIVE so benchmarking and debugging can easily force the pure-Python path. Add coverage for the env-var gate. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Benchmark report
This benchmark check is informational and does not block merging. Deltas below compare benchmark Notable improvements
Notable regressions
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove the non-empty native-update duplicate-value prescan so mapping updates preserve the same duplication-error precedence as the Python path, and update native tests to pin the intended routing and precedence behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Benchmark notes
Follow-up before ready for review
CHANGELOG.rstwith release-note coverage for the optional native helper and the related CI/tooling additions