Skip to content

macOS: render entity models via VBO, not empty display lists #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
j92580498-max merged 1 commit into from
May 15, 2026
Merged

macOS: render entity models via VBO, not empty display lists #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions handheld/src/client/model/geom/ModelPart.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,16 @@ void ModelPart::translateTo( float scale )

void ModelPart::compile( float scale )
{
#ifndef OPENGL_ES
// Gate the display-list path on USE_VBO, not OPENGL_ES. On macOS
// desktop GL 2.1 the engine has USE_VBO defined (see gles.h)
// but OPENGL_ES is not, so the old condition wrapped the
// tesselator call in glNewList/glEndList while Tesselator::end
// (under USE_VBO) only uploads to the VBO and never issues a
// draw. The display list was therefore empty and glCallList()
// drew nothing -- the cause of the missing player preview in
// the Armor screen. Same shape of bug as the chunk VBO
// regression fixed in baa7155.
#ifndef USE_VBO
list = glGenLists(1);
// FIX NORMAL BUG HERE
glNewList(list, GL_COMPILE);
Expand All @@ -194,15 +203,15 @@ void ModelPart::compile( float scale )
cubes[i]->compile(t, scale);
}
t.end(true, vboId);
#ifndef OPENGL_ES
#ifndef USE_VBO
glEndList();
#endif
compiled = true;
}

void ModelPart::draw()
{
#ifdef OPENGL_ES
#ifdef USE_VBO
drawArrayVT_NoState(vboId, cubes.size() * 2 * 3 * 6, 24);
#else
glCallList(list);
Expand Down
Loading