chore: lower the bar for local and agentic onboarding - #123
Merged
Conversation
Require only Clerk + APP_* for first-run, document personal Environments and agent login vars, and fence operator-only Cursor/Workers paths.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (3)
🔇 Additional comments (5)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe pull request updates local development documentation, environment examples, secret classification, Vite startup checks, and environment verification. Required Clerk and application keys are separated from optional infrastructure and agent-login keys. ChangesLocal development environment
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Line 298: Update the ordered-list item in the README section to use the
configured `1.` prefix instead of `3.`, preserving the existing list content and
numbering behavior.
- Around line 300-304: Remove the README example that uses `op run --no-masking
-- printenv AGENT_LOGIN_EMAIL`; replace it with a safe browser-automation
invocation that passes both required credentials directly within `op run`,
without printing or disabling masking for secrets.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 5296c8d7-4165-4724-9234-9368a0627c11
📒 Files selected for processing (9)
CONTRIBUTING.mdREADME.mdSECURITY.mdapps/web/.dev.vars.exampleapps/web/.op/refs.env.examplescripts/lib/local-dev-secrets.mjsscripts/lib/local-dev-secrets.test.tsscripts/run-vite-dev.mjsscripts/verify-dev-environment.mjs
📜 Review details
⏰ Context from checks skipped due to timeout. (1)
- GitHub Check: test
🧰 Additional context used
🪛 markdownlint-cli2 (0.23.2)
README.md
[warning] 298-298: Ordered list item prefix
Expected: 1; Actual: 3; Style: 1/1/1
(MD029, ol-prefix)
🔇 Additional comments (9)
scripts/lib/local-dev-secrets.mjs (1)
1-53: LGTM!scripts/lib/local-dev-secrets.test.ts (1)
1-72: LGTM!scripts/run-vite-dev.mjs (1)
15-15: LGTM!Also applies to: 25-47
scripts/verify-dev-environment.mjs (1)
7-61: LGTM!CONTRIBUTING.md (1)
19-59: LGTM!README.md (1)
101-173: LGTM!Also applies to: 241-241, 270-297, 306-310
SECURITY.md (1)
50-51: LGTM!apps/web/.dev.vars.example (1)
6-46: LGTM!apps/web/.op/refs.env.example (1)
9-11: LGTM!
Use markdownlint-compliant list prefixes and drop the unmasked printenv example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
APP_ENV,APP_ORIGIN, and Clerk keys; Cloudflare IDs and VAPID are optional (dev:verify/run-vite-dev)AGENT_LOGIN_EMAIL/AGENT_LOGIN_PASSWORDfor agentic Clerk login via each developer’s 1Password Environment (never commit passwords)Test plan
APP_ENV+APP_ORIGIN+ Clerk only →pnpm run dev:verifypasses (optional keys noted, not failed)dev:verifyfails clearlyAGENT_LOGIN_*in Environment: agent can sign in via Clerk UI and reach the apppnpm exec vitest run scripts/lib/local-dev-secrets.test.ts