Maintenance: upgrade connection_pool to v3 + dependency bumps#86
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
rubocop 1.87 pulled parallel 2.1.0, which requires Ruby >= 3.3 and broke the Ruby 3.2 CI job. The gemspec still declares required_ruby_version >= 3.2.9, so cap parallel at 1.x rather than drop 3.2. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Ruby 3.2 reached end-of-life on 2026-03-31. Require Ruby >= 3.3.0, remove 3.2 from the CI matrix, bump rubocop TargetRubyVersion to 3.3, and drop the temporary 'parallel < 2.0' pin (parallel 2.x requires Ruby >= 3.3, now satisfied). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
jKatt
reviewed
Jun 2, 2026
| ruby 4.0.2 | ||
| nodejs 24.14.1 | ||
| ruby 4.0.5 | ||
| nodejs 26.2.0 |
Contributor
There was a problem hiding this comment.
I would suggest we stick to the current LTS version
Suggested change
| nodejs 26.2.0 | |
| nodejs 24.16.0 |
Per review: pin nodejs to the active LTS line rather than the Current release for the prettier/lint step. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
jKatt
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Routine maintenance pass + bring
connection_poolonto v3.What
~> 2.4→~> 3.0(locked 3.0.2). v3's only breaking change is positional→keyword args oncheckout/reap; ears uses only.new(size:, timeout:),.with,.shutdown, so no code change needed. v3 requires Ruby ≥ 3.2 (gemspec already>= 3.2.9)..tool-versionsruby 4.0.2→4.0.5, nodejs→26.2.0; CIbuild.ymlnode-version→26; prettier 3.8.1→3.8.3.CLAUDE.md; aligndependabot.ymlto org multi-ecosystem-group (security) shape.Verify
bundle exec rubocop— 40 files, 0 offensesbundle exec rspec— 275 examples, 0 failures (99.13% line coverage)🤖 Generated with Claude Code