fix: restore static typing of inject.attr(Cls)#136
Merged
ivankorobkov merged 2 commits intoJun 27, 2026
Conversation
Owner
|
Cool, thank you for the fix. I will make the next release now. |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I recently opened issue #135 to report the static typing regression. Today, I looked into this myself using AI (Claude Opus 4.8).
The actual fix is tiny:
before:
after:
Verified locally via `uvx --with tox-uv tox -e lint-types`
We've basically swapping the order so that the typed one matches first.
The rest of the PR is adding a test + wiring it into the tox setup. I created a separate job as
tox -e lint-py(Lint formatting) is failing and the new public API type checks would never run.Best
Fixes #135