Repository navigation
Fix CLI quirks: blocking_mode, config errors, NOOP report crash, Python name matching - #536
Open
ivanklee86 wants to merge 7 commits into
Open
ivanklee86 wants to merge 7 commits into
ivanklee86 wants to merge 7 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
NOOP results were included in the violations table but had no result text, causing an UnboundLocalError or a row with stale text. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
grade printed the ValidationError but continued, then crashed with a NameError. Both commands now use load_config, which exits with code 1 on an invalid config. print_error is annotated NoReturn to match its behavior. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The env var was misspelled as RUBGRICAL_DEBUG; the old name is still accepted for backwards compatibility. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
--block/--no-block now defaults to the config's blocking_mode (default true) and overrides it when given. Previously blocking_mode was never read. When blocks are found but blocking is off, rubrical now says so instead of printing 'All dependencies up to date!'. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Python names are now compared per PEP 503 (case-insensitive; runs of -, _ and . are equivalent), so 'mopidy_dirble' in the config matches 'Mopidy-Dirble' in requirements.txt. Other package managers keep exact matching via the new BasePackageManager.normalize_name hook. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. 鈿欙笍 Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes six quirks found while documenting the codebase. Each fix is its own commit with a regression test.
UnboundLocalErroror stale text. Only WARN and BLOCK results are listed now, the same as the GitHub report.grade: theValidationErrorwas printed, then the command crashed with aNameError.gradeandconfigs validatenow shareload_config(), which exits with code 1.print_erroris typedNoReturn.RUBRICAL_DEBUGnow works, andRUBGRICAL_DEBUGis still accepted for backwards compatibility.blocking_modewas ignored:--block/--no-blocknow defaults to the config'sblocking_mode(defaulttrue) and overrides it when given. If blocks are found while blocking is off, rubrical says so instead of printing "All dependencies up to date!".mopidy_dirblematchesMopidy-Dirble. Other package managers keep exact matching through a newBasePackageManager.normalize_namehook.rubrical/rubrical.py.Behavior changes
blocking_mode: falsein a config now changes the exit code. Previously the setting had no effect.blocking_mode: nullnow fails validation, because the field is nowbool.Testing
task python:lintandtask python:testpass (44 passed, 4 skipped; the skipped tests are the GitHub tests, which need a token).mkdocs build --strictpasses.docs/commands.mdwas regenerated anddocs/configuration.mdupdated.馃 Generated with Claude Code