Repository navigation
Move devcontainer onto the shared python base - #535
Merged
Merged
Conversation
- Generate .devcontainer/devcontainer.json with gantry from the shared python base + prek feature + rubrical.libsonnet; drop the local Dockerfile. - Replace pre-commit with prek: remove it from the dev group, stop installing it in post_install.sh, and run hooks in CI via prek-action. - Add renovate-config-validator hook, a devcontainer Renovate group (replacing the dead poetry rule), and `task devcontainer:gen`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QZNfQpK1WefqNQLRrHHXfe
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.devcontainer/devcontainer.jsonis now generated by gantry from the shared python base, theprekfeature andrubrical.libsonnet. The local Dockerfile is removed becausepython:3.14already provides uv, Python 3.14 and task. Regenerate withtask devcontainer:gen.pre-commitis removed from thedevgroup;uv.lockonly drops packages.post_install.shno longer installs pre-commit hooks.pre-commitjob that runsj178/prek-action(pinned SHA, prek 0.5.3).renovate-config-validatorhook, and replaces the deadpoetryrule with adevcontainergroup that automerges.The uv cleanup (redundant
setup-pythonpip caching, the poetry install inrelease-docs,isort/pipin dev deps) is deliberately left for a follow-up.Depends on
ivanklee86/devcontainers#56. This PR's
devcontainer.jsonwas generated against that branch, so it only matches whatmaingenerates once #56 merges. It also points atpython:3.14, an image tag that doesn't exist until #56 publishes it.Testing
Tested in a locally built
python:3.14image:post_install.shandprek install && prek runboth succeed.prek run --all-files: all 7 hooks pass.task: ruff and ty pass; 35 tests pass. The 4 GitHub reporter tests fail locally withoutRUBRICAL_TEST_GITHUB_ACCESS_TOKEN, the same as onmain.task docs:testpasses.renovate-config-validatorpasses.Before / after merging
task devcontainer:genand confirm there's no diff.:4, the mounts, and createsdevcontainer-lock.jsonto commit.🤖 Generated with Claude Code
https://claude.ai/code/session_01QZNfQpK1WefqNQLRrHHXfe