implementing DOWNLOAD_EXTRA_CONFIGS - #3679
Merged
Merged
Conversation
Owner
I see what you mean that there's not a perfect spot for it. I think I prefer the one you found. Another that might be ok is the top level https://docker-minecraft-server.readthedocs.io/en/latest/mods-and-plugins/ since it mentions /config mount. |
Contributor
Author
|
I don't know why CI fails. Docs are good like that? |
Owner
I'll re-run. I think it was just waiting for my approval. |
itzg
approved these changes
Sep 30, 2025
itzg
left a comment
Owner
There was a problem hiding this comment.
Docs look great. I'll see what the build thinks 😉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: #3658
This PR aims to provide a way to download configs or other files before server startup in order to patch them.
With this change, files can be downloaded by using the
DOWNLOAD_EXTRA_CONFIGSenvironment variable.For example:
or
The backend
mc-image-helperfunctionmcopywas enhanced by itzg/mc-image-helper#641There is currently no option to provide file listings like with
MODRINTH_PROJECTSsincemcopyneeds an extra flag for that.I also did not try to integrate the existing downloading of config files into this, because I feel like it should stay seperate.
I haven't documented the change yet, because I don't know where to put it best. Maybe the /configuration/misc-options/ ?