Adds initial Node.js Helm chart - #6
Open
kaaalim wants to merge 7 commits into
Open
Conversation
Initializes a Helm chart for deploying Node.js applications on Kubernetes. The chart includes configurations for: - Deployment - Service - Ingress - Autoscaling - ConfigMaps for Nginx - Secrets management This provides a foundation for easily deploying and managing Node.js applications within a Kubernetes cluster.
Updates chart and app versions to the initial development release 0.0.1. This reflects the start of the nodejs-helm feature development.
Initializes a Helm chart for deploying Node.js applications on Kubernetes. The chart includes configurations for: - Deployment - Service - Ingress - Autoscaling - ConfigMaps for Nginx - Secrets management This provides a foundation for easily deploying and managing Node.js applications within a Kubernetes cluster. fix(chart): Correct appVersion for nodejs chart Initializes chart version to 0.0.1 Updates chart and app versions to the initial development release 0.0.1. This reflects the start of the nodejs-helm feature development.
DanyaCt
reviewed
May 21, 2026
|
|
||
| {{- if .Values.nodejs.env.envFromSecretsManager.enabled }} | ||
| --- | ||
| apiVersion: external-secrets.io/v1beta1 |
Contributor
There was a problem hiding this comment.
The ExternalSecret here is still on external-secrets.io/v1beta1, but we changed every other chart in this repo to v1. Please update the apiVersion
DanyaCt
reviewed
May 21, 2026
| - name: http | ||
| containerPort: {{ .Values.nodejs.port | default "3000" }} | ||
| protocol: TCP | ||
| livenessProbe: |
Contributor
There was a problem hiding this comment.
The livenessProbe and readinessProbe in the deployment template currently render unconditionally, but their defaults are commented out in values.yaml. On a stock install, this generates empty keys, causing the Pod spec to fail validation. To avoid this, it is advisable to wrap them in {{- with .Values.livenessProbe }} blocks to ensure they only render when defined
DanyaCt
reviewed
May 21, 2026
| # Virtual Host Configs | ||
| ## | ||
| upstream nodejs_upstream { | ||
| server localhost:3000; |
Contributor
There was a problem hiding this comment.
Port 3000 is currently hard-coded, and if someone changes the default port number in the values.yaml in the future, this configuration will still use port 3000, which will cause problems. Worth templating that line
…chart - Add optional preDeployJob (Helm pre-install/pre-upgrade hook) with its own Job and Secret templates, mirroring the nextjs chart pattern - Add nodejs.env.existingSecretName to allow mounting an externally managed Secret instead of the one rendered by the chart - Support custom ingress backend service name/port per path via dig - Wrap nginx/nodejs liveness and readiness probes in `with` so they're omitted when unset - Bump external-secrets ExternalSecret apiVersion to v1 - Template the nginx upstream port from .Values.nodejs.port - Bump chart version to 0.1.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initializes a Helm chart for deploying Node.js applications on Kubernetes.
The chart includes configurations for:
This provides a foundation for easily deploying and managing Node.js applications within a Kubernetes cluster.