set: module content default private - #120
Merged
Merged
Conversation
Every module under src/ now declares `private` after `implicit none` and lists its API explicitly with `public ::`. Only entities actually used by other modules, app/main.f90, or the tests are exported; everything else (internal helpers, abstract interfaces for callbacks, module state used only inside the module) becomes private. Newly private, i.e. previously public but never used outside their module: - constants: eps - utils: not_same_scalar/_array/_matrix, contains_nan - integrate: quadkind, quadkind_integrand, convert_to_quadkind, convert_to_dp - find_extrema: func1d, negative_func, cannot_resolve, cannot_resolve_at_edge - fourier_field: next_power_of_two, fft_1d, the compute_* bindings - fieldline_mod: get_theta_scalar, get_theta_array - fieldline_labels: calc_iota, is_multiple_of_2pi - make_fieldline: check_if_valid_input, estimate_symmetry_violation, pick_maximum, nudge_maxima_inward - deviation: has_sin_modes - fit_functions: eps - field_base: the deferred-binding interfaces - shaing_callen_mod: calc_avg_lambda_over_B_squared - read_file: ds_dr, check_if_valid_namelist, the rabe_config namelist group error_handling additionally gains the default `private` it was missing and exports reset_failed_check_counter, which app/main.f90 and the unit test already used implicitly. No behaviour or interface changes; `make test` (36/36) passes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Sry29kVN4WeR9ozM1PaYeg
refactor: make module entities private by default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Public interfaces for user and tests are specified explicitly - cleans up the docs generation of
FORD.