feat: gør status-, advarsels- og fejlbokse mere synlige - #222
Open
martinydeAI wants to merge 1 commit into
Open
Conversation
Brugertest viste at ansvarsboksen i delingsflowet forsvandt i siden, selvom den bærer information man skal huske netop når man deler. Samme problem gjaldt statusboksene generelt: med surface på 50-trinnet og kant på 200-trinnet havde kanten kun omkring 1,2-1,3:1 kontrast mod siden. Paletten flyttes til surface 100 og kant 500/600, så hver kant klarer 3:1-kravet til ikke-tekstkontrast mod hvid. Tekst holder fortsat WCAG AA mod sin egen baggrund — 6,37:1 i det strammeste tilfælde. Ansvarsboksen på /assistant/new og /assistant/edit flyttes fra den neutrale flade til advarselspaletten. Kun farveværdier og farveklasser: ingen ændring af markup, ARIA-roller, kantbredde, ikoner eller typografi, så Alert- komponentens klassekontrakt og AlertRenderTest er urørte. Refs #221 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This was referenced Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Links to issues
Closes #221
Leantime ticket: 8223.
Description
Status, warning, and error boxes were too pale to register. The palette
sat at surface-50 / border-200, which left the border at roughly 1.2–1.3:1
against the page — the box receded exactly when it was meant to interrupt.
/assistant/newand/assistant/editmoves off the neutral surface onto the warning palette (8223).
Colour values and colour classes only — no markup, ARIA role, border
width, icon, or typography change.
#dbeafe#3b82f6#1e40af#d1fae5#059669#065f46#fef3c7#d97706#92400e#fee2e2#ef4444#991b1bScreenshot of the result
Not included — the affected pages sit behind authentication and I could not
drive the stateless-CSRF login from the sandbox. The compiled stylesheet was
inspected instead:
var/tailwind/app.built.csscarries all twelve new tokenvalues, and
.bg-warning-surface/.border-warning-line/.text-warning-inkare emitted for the responsibility box. A reviewer should eyeball the actual
pages — this is a visual change and contrast maths is not a substitute for
looking at it.
Checklist
Markdown lint could not be run locally:
itkdev/markdownlint's arm64 manifestentry contains x86-64 binaries, so the container exits with
exec format erroron aarch64. CI will cover it.
Details - AI specificities
Why token values rather than new classes.
AlertRenderTestpins eachtype's
bg-*-surface border-*-line text-*-inktriple. Changing the valuesbehind those names keeps the contract intact, so the component, its ARIA
roles, and its tests need no edit at all. No test file is touched by this PR.
Why the responsibility box is not a
<twig:Alert>. CLAUDE.md prefers theshared component, and this box is the obvious candidate — but
Alertmapswarningtorole="alert", which is assertive. This notice is static pagefurniture present on every load, so an assertive role would make a screen
reader interrupt on arrival every time. It stays an
<aside role="note">andborrows the warning palette. Worth a reviewer's opinion; if you disagree, the
swap is two lines.
Deliberate side effect. The data-sensitivity pills in
templates/assistant/show.html.twigreuse these same tokens and deepen alongwith the alerts. That is the intended behaviour — same signal, same strength —
but it is a visible change beyond the alert boxes and should be looked at.
Amber.
#d97706reaches 3.19:1 against white, the lowest of the four.Pushing to amber-700 would buy more contrast at the cost of the hue reading
as brown rather than caution, so the value stands.
Verification.
task test— 690 tests, 2039 assertions, green.task test-coverageis 100% oncesrc/DataFixtures/LocalUserFixtures.phpisexcluded; that file is gitignored and untracked, so it does not exist in CI.
Twig CS Fixer and Prettier (CSS) pass. Contrast figures above were computed
with the WCAG 2.x relative-luminance formula.
Non-goals. The other Layout tickets from the same user-testing round —
8212 (stretched logo) and 8215 (CTA placement, pending a decision from
Jesper P.) — are left for follow-up on this branch's successors.