Skip to content

fix: ensret terminologi til download og vejledning - #220

Open
martinydeAI wants to merge 1 commit into
developfrom
feature/issue-219-copy-terminology
Open

fix: ensret terminologi til download og vejledning#220
martinydeAI wants to merge 1 commit into
developfrom
feature/issue-219-copy-terminology

Conversation

@martinydeAI

Copy link
Copy Markdown
Collaborator

Links to issues

Closes #219

Leantime tickets: 8214, 8216, 8218, 8221, 8222, 8224, 8225.

Description

User testing showed the interface used three different words —
"hjemtag", "eksportér", "download" — for one and the same action, and
that "vidensopskrift" meant nothing to non-technical curators.

  • One verb for fetching an assistant: everything is now download.
  • "Vidensopskrift" becomes vejledning, including the Viden tab heading.
  • Front page no longer says "resten" about the other municipalities.
  • "Mine assistenter" lead drops the unexplained "nye tilføjelser".
  • Share wizard's paste-field help is cut to what it actually promises.
  • Responsibility notice names the guidance, not "en opskrift på datagrundlaget".
  • JSON tab offers OpenWebUI only; the export route still accepts
    ?format= for every registered format.

translations/messages.da.yaml carries most of the change. The front-page
tagline and hero text are also seeded in
src/DataFixtures/SettingFixtures.php — the seeded values win at runtime,
so both are updated.

Screenshot of the result

Not included — the affected pages sit behind authentication and I could not
drive the stateless-CSRF login from the sandbox. Verified through the
integration suite instead (see below).

Checklist

  • My code is covered by test cases.
  • My code passes our test (all our tests).
  • My code passes our static analysis suite.
  • My code passes our continuous integration process.

Markdown lint could not be run locally: itkdev/markdownlint's arm64
manifest entry contains x86-64 binaries, so the container exits with
exec format error on aarch64. CI will cover it. (Same defect in
itkdev/mariadb:latest — worth reporting upstream separately.)


Details - AI specificities

Goal. One consistent verb for the fetch action and a word for the
data-requirements document that the target audience recognises.

Test changes. Three assertions pinned strings this PR rewrites, and
were updated to match — no assertions weakened, none skipped:

  • AssistantControllerTest.php:118VidensopskriftVejledning
  • AssistantControllerTest.php:119Eksportér konfigurationDownload konfiguration
  • AssistantCatalogControllerTest.php:306aside[aria-label="Klar til hjemtagning"]"Klar til download"

8225 implementation. AssistantController::show() passes a
single-entry exportFormats map and only the warnings for that format,
rather than filtering in Twig, keeping the controller thin and leaving
AssistantExporter::warningsByFormat() (unit-tested) in use. The template
loop collapses from nested to flat accordingly. No adapter was
unregistered, so import/detection and ?format= exports are untouched.

Verification. task test — 690 tests, 2039 assertions, all green.
task test-coverage reports 100% once src/DataFixtures/LocalUserFixtures.php
is excluded; that file is gitignored and untracked, so it does not exist in
CI. PHP CS Fixer, Twig CS Fixer, Prettier (on the changed YAML), and
composer validate/normalize all pass.

Not verified. The single-button rendering of the JSON tab was not
exercised in a browser — it follows from the controller passing a
one-entry array that the template iterates, and the tab renders without
error under testEachTabRendersItsPartial. No test asserts the button
count; worth a reviewer's eye.

Non-goals. The other themes from the same user-testing round —
catalogue filters (8213, 8217, 8220), layout (8212, 8215, 8223), form
behaviour (8211, 8219), and access control (8210) — are deliberately left
out and tracked separately.

Brugertest viste at brugerfladen skiftede mellem "hjemtag",
"eksportér" og "download" om den samme handling, og at ordet
"vidensopskrift" ikke blev genkendt af ikke-tekniske brugere.
Alle forekomster er nu "download" henholdsvis "vejledning".

Forsidens eyebrow og hero-tekst findes både som oversættelser
og som seedede settings; de seedede værdier vinder i runtime,
så begge er rettet.

JSON-fanen tilbyder nu kun OpenWebUI som download. Curatorer
blev bedt om at vælge mellem fem udvekslingsformater uden
grundlag for at vælge, og de medfølgende advarselstrekanter
stod uforklarede. Eksport-ruten accepterer fortsat ?format=
for alle registrerede formater.

Refs #219

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

task: ensret terminologi i brugerfladen (download / vejledning)

1 participant