fix: ensret terminologi til download og vejledning - #220
Open
martinydeAI wants to merge 1 commit into
Open
Conversation
Brugertest viste at brugerfladen skiftede mellem "hjemtag", "eksportér" og "download" om den samme handling, og at ordet "vidensopskrift" ikke blev genkendt af ikke-tekniske brugere. Alle forekomster er nu "download" henholdsvis "vejledning". Forsidens eyebrow og hero-tekst findes både som oversættelser og som seedede settings; de seedede værdier vinder i runtime, så begge er rettet. JSON-fanen tilbyder nu kun OpenWebUI som download. Curatorer blev bedt om at vælge mellem fem udvekslingsformater uden grundlag for at vælge, og de medfølgende advarselstrekanter stod uforklarede. Eksport-ruten accepterer fortsat ?format= for alle registrerede formater. Refs #219 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Links to issues
Closes #219
Leantime tickets: 8214, 8216, 8218, 8221, 8222, 8224, 8225.
Description
User testing showed the interface used three different words —
"hjemtag", "eksportér", "download" — for one and the same action, and
that "vidensopskrift" meant nothing to non-technical curators.
?format=for every registered format.translations/messages.da.yamlcarries most of the change. The front-pagetagline and hero text are also seeded in
src/DataFixtures/SettingFixtures.php— the seeded values win at runtime,so both are updated.
Screenshot of the result
Not included — the affected pages sit behind authentication and I could not
drive the stateless-CSRF login from the sandbox. Verified through the
integration suite instead (see below).
Checklist
Markdown lint could not be run locally:
itkdev/markdownlint's arm64manifest entry contains x86-64 binaries, so the container exits with
exec format erroron aarch64. CI will cover it. (Same defect initkdev/mariadb:latest— worth reporting upstream separately.)Details - AI specificities
Goal. One consistent verb for the fetch action and a word for the
data-requirements document that the target audience recognises.
Test changes. Three assertions pinned strings this PR rewrites, and
were updated to match — no assertions weakened, none skipped:
AssistantControllerTest.php:118—Vidensopskrift→VejledningAssistantControllerTest.php:119—Eksportér konfiguration→Download konfigurationAssistantCatalogControllerTest.php:306—aside[aria-label="Klar til hjemtagning"]→"Klar til download"8225 implementation.
AssistantController::show()passes asingle-entry
exportFormatsmap and only the warnings for that format,rather than filtering in Twig, keeping the controller thin and leaving
AssistantExporter::warningsByFormat()(unit-tested) in use. The templateloop collapses from nested to flat accordingly. No adapter was
unregistered, so import/detection and
?format=exports are untouched.Verification.
task test— 690 tests, 2039 assertions, all green.task test-coveragereports 100% oncesrc/DataFixtures/LocalUserFixtures.phpis excluded; that file is gitignored and untracked, so it does not exist in
CI. PHP CS Fixer, Twig CS Fixer, Prettier (on the changed YAML), and
composer validate/normalize all pass.
Not verified. The single-button rendering of the JSON tab was not
exercised in a browser — it follows from the controller passing a
one-entry array that the template iterates, and the tab renders without
error under
testEachTabRendersItsPartial. No test asserts the buttoncount; worth a reviewer's eye.
Non-goals. The other themes from the same user-testing round —
catalogue filters (8213, 8217, 8220), layout (8212, 8215, 8223), form
behaviour (8211, 8219), and access control (8210) — are deliberately left
out and tracked separately.