fix(catalog): render organisation name in details breadcrumb - #203
Merged
Conversation
The assistant details page breadcrumb rendered the raw translation identifier `assistant.detail.placeholder_origin` because the key was left as a placeholder and never wired to a translation entry. Symfony's translator fell back to the key, leaking a dotted identifier into the UI. Replace the placeholder with the already-computed `organization_name` variable from show.html.twig:6, so the breadcrumb reads `Katalog / <organisation>` (or `Katalog / Ingen tilknyttet organisation` on assistants without an organisation), matching the eyebrow line just below. Fixes #197 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
martinyde
previously approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Links to issues
Fixes #197
Description
The assistant details page breadcrumb rendered
assistant.detail.placeholder_originverbatim — the key was left asa placeholder and no Danish translation entry was ever added, so
Symfony's translator fell back to the identifier itself and users
saw the dotted string.
templates/assistant/show.html.twig:16now renders thealready-computed
organization_namevariable from line 6, sothe breadcrumb reads
Katalog / <organisation>orKatalog / Ingen tilknyttet organisationmatching the eyebrowline just below.
no_organizationfallbackcopy is already used by
organization_nameon line 6.Screenshot of the result
To be added — please eyeball the breadcrumb on one assistant with
an organisation and one without before merging.
Checklist
Existing
AssistantControllerTest::testRendersDefaultTab()alreadyasserts that "Aarhus Kommune" appears in the article (
header + breadcrumb render the real organisation name), andtestFallbackCopyForUnattachedAssistant()already asserts theIngen tilknyttet organisationfallback appears in the body. Bothexisting assertions become MORE aligned with reality after the fix
(they previously passed on the header-eyebrow occurrence alone,
with the breadcrumb still leaking the placeholder key). No test
edits needed.
Details - AI specificities
Goal
Stop leaking raw translation identifiers into the UI. The breadcrumb
is one of the first things a visitor sees on an assistant page and a
raw
namespace.section.keystring undermined confidence in thecatalog.
Scope
templates/assistant/show.html.twig— one line (16).Non-goals
substring that the fix makes truly present in the breadcrumb.
Decisions
organization_name(already computed on line 6 for theeyebrow at line 33) instead of introducing a separate variable or
keeping a static translation key. The breadcrumb and the eyebrow
should show the same value; sourcing them from the same variable
keeps them in lock-step.
assistant.detail.placeholder_origintranslation — would havebeen the wrong fix because the intent was always to render data,
not a static label (per the issue's Constraints section).
Verification
task coding-standards-check→ clean.task test→ 685 tests, 2034 assertions, all green.assistant with an organisation and one without.
Links