Feature/single letters - #49
Open
ghbm-itk wants to merge 30 commits into
Open
Conversation
Eight files had been committed with CRLF line endings, which made their diffs unreviewable (send_post.py showed 896 changed lines with no actual content change). Renormalized with `git add --renormalize`; this commit changes line endings only. Root cause was core.autocrlf=false locally, which commits worktree bytes verbatim. Now set to `input` globally so CRLF is normalized on commit while nothing is converted on checkout. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
jekuaitk
requested changes
Jul 30, 2026
jekuaitk
left a comment
jekuaitk
left a comment
Contributor
There was a problem hiding this comment.
A couple suggestions and questions otherwise good!
Comment on lines
+15
to
+23
| def check_bearer_token(credentials: HTTPAuthorizationCredentials = Depends(security_scheme)) -> dict[str, str]: | ||
| """Check the validity of an incoming bearer JWT token.""" | ||
| try: | ||
| payload = jwt.decode(credentials.credentials, config.API_JWT_SECRET, algorithms=["HS256"]) | ||
| return payload | ||
| except jwt.ExpiredSignatureError: | ||
| raise HTTPException(401, "Token expired") # pylint: disable=raise-missing-from | ||
| except jwt.InvalidTokenError: | ||
| raise HTTPException(401, "Invalid token") # pylint: disable=raise-missing-from |
Contributor
There was a problem hiding this comment.
Should we also check whether the api user is active? Seems like a deactivated API-user can keep using an already issued JWT until it expires, that is worst case up to api_token_lifetime_seconds.
|
|
||
|
|
||
| @router.get("/letter/{letter_id}", tags=["Letters"]) | ||
| def get_letter(letter_id: str, get_pdf: bool = True) -> LetterDetail: |
Contributor
There was a problem hiding this comment.
Seems like any API-user can fetch any letter (provided they know their id). Is this on purpose?
Comment on lines
+301
to
+305
| for letter in letters: | ||
| document_storage.delete_single_letter_doc(letter.id) | ||
| session.delete(letter) | ||
|
|
||
| session.commit() |
Contributor
There was a problem hiding this comment.
Would it make sense to re-order this such that the actual document are only deleted after committing? Perhaps even collecting the letter ids in a list and then deleting them after a single commit?
Suggested change
| for letter in letters: | |
| document_storage.delete_single_letter_doc(letter.id) | |
| session.delete(letter) | |
| session.commit() | |
| for letter in letters: | |
| session.delete(letter) | |
| session.commit() | |
| document_storage.delete_single_letter_doc(letter.id) |
| return tuple(result) | ||
|
|
||
|
|
||
| def get_api_user(id: str) -> ApiUser: |
Contributor
There was a problem hiding this comment.
Should this not be
Suggested change
| def get_api_user(id: str) -> ApiUser: | |
| def get_api_user(id: str) -> ApiUser | None: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
Changed