Closed
Detach closed Transfers window from shared transfer listeners#18325
Conversation
|
|
1 similar comment
|
|
Copilot
AI
changed the title
[WIP] Fix invisible transfer windows on macOS after closing
Detach closed Transfers window from shared transfer listeners
Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing the Transfers window on macOS could leave behind transparent window instances that still intercepted clicks. The leak was specific to the transfer window lifecycle: closed controllers remained subscribed to the shared transfer collection and continued to receive updates after teardown.
Transfer window lifecycle
TransferControllercollection listeners as fields instead of anonymous one-offsinvalidate()Transfer row controller cleanup
TransferTableDataSourcean explicit collection listener lifecycleinvalidate()ProgressControllerinstances on teardown so closed windows no longer retain row controllersRegression coverage
TransferControllerandTransferTableDataSourceremove theirTransferCollectionlisteners when invalidated