Storyboard - #480
Open
fluddokt wants to merge 2 commits into
Open
Conversation
added 2 commits
August 18, 2018 18:15
mostly working
known bugs: bleeding texture especially on single pixel images. probably contains other bugs
itdelatrisu
requested changes
Apr 28, 2019
itdelatrisu
left a comment
itdelatrisu
left a comment
Owner
There was a problem hiding this comment.
Hey, nice seeing you again!
Can you give an example beatmap that you're using this with? I tried a few (like the old tutorial) and am not seeing anything in-game, just a lot of "unknown token" in console.
| * along with opsu!. If not, see <http://www.gnu.org/licenses/>. | ||
| */ | ||
|
|
||
| //TODO revert this file |
| } | ||
|
|
||
| //https://osu.ppy.sh/help/wiki/Storyboard_Scripting/General_Rules#game-state | ||
| boolean PASSING = true, FAILING = false; |
Owner
There was a problem hiding this comment.
no need to define variables here IMO
|
|
||
| //https://osu.ppy.sh/help/wiki/Storyboard_Scripting/General_Rules#game-state | ||
| boolean PASSING = true, FAILING = false; | ||
| int passingBreakCnt = 0, failingBreakCnt = 0; //used for states after last playtime.... |
| // skip intro | ||
| if (!gameFinished) | ||
| skipIntro(); | ||
| //TODO delete me |
| if (storyboard != null) { | ||
| if (storyboard.file.equals(beatmap.getFile())) { | ||
| storyboard.reset(); | ||
| storyboard.dispose();//TODO del |
| if (storyboard.file.equals(beatmap.getFile())) { | ||
| storyboard.reset(); | ||
| storyboard.dispose();//TODO del | ||
| storyboard = null;//TODO del |
| throws SlickException { | ||
| this.container = container; | ||
|
|
||
| GL11.glPixelStorei(GL11.GL_UNPACK_ALIGNMENT, 1); |
| public enum TriggerEvent { | ||
| Passing, Failing, HitSoundFinish, HitSoundWhistle, HitSoundClap, None; | ||
|
|
||
| public static TriggerEvent toTriggerEvent(String s) { |
Owner
There was a problem hiding this comment.
You can use:
try {
return TriggerEvent.valueOf(s);
} catch (IllegalArgumentException e) {
return TriggerEvent.NONE;
}
There was a problem hiding this comment.
Relying on try-catch logic is a code smell for me.
|
I get this exception trying to run world.execute(me); Animation frame delays supports decimal numbers. I advise you to use this and this as benchmarks. |
CloneWith
added a commit
to CloneWith/opsu
that referenced
this pull request
Aug 3, 2024
Most of the work comes from fluddokt, see itdelatrisu/opsu#480
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.