fix image stored files were never retrieved in file storage - #1
Open
eviweb wants to merge 3 commits into
Open
Conversation
Signed-off-by: Eric Villard <dev@eviweb.fr>
This allows to embed images from other plugins. Signed-off-by: Eric Villard <dev@eviweb.fr>
Author
|
Hi, |
Signed-off-by: Eric Villard <dev@eviweb.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
the hash of the file path you used to retrieve an image stored file was not the same as the one that was calculated when the image file was stored.
The variables
$componentand$fileareaI used in my patch should not be hardcoded, but I didn't find any good solution for now and have no more time to investigate a better solution.