Update stale - #77
Open
charlesRmajor wants to merge 7 commits into
Open
Conversation
istornz
requested changes
Mar 6, 2024
istornz
left a comment
istornz
left a comment
Owner
There was a problem hiding this comment.
LGTM, can you please look at my two little comments/suggestions? 🥇
istornz
approved these changes
Apr 4, 2024
Owner
|
@charlesRmajor Sorry for the delay, I was in vacation :/ It's good for me, can you fix conflicts before merging? Thanks a lot! |
EArminjon
reviewed
Feb 11, 2025
| } | ||
| } | ||
|
|
||
| Future<File> _compressToSize( |
Contributor
There was a problem hiding this comment.
What is the purpose of this compress ?
Contributor
|
Is this will be merged ? |
Owner
|
@EArminjon I hope but we need to fix conflicts before |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update "update" function to match Apple's updated method, including supporting staleIn time same as in createActivity.
The previous method has been deprecated
NOTE: this new "update" function requires iOS version 16.2, not 16.1. I replaced all of the 16.1's with 16.2, but I don't know if that's what you'll want for the package. My need definitely doesn't cover supporting users who insist on being on 16.1.
(Thanks for making this easy for us, Apple, lol)